YT_DEFINE_GLOBAL for profilers

babenko · babenko · commit 205da070631b · 2024-11-22T17:01:27.000+03:00
commit_hash:c9f0f790039ceeef149366a14c9063025fbb1e0c
diff --git a/yt/yt/core/bus/private.h b/yt/yt/core/bus/private.h
@@ -13,7 +13,7 @@ namespace NYT::NBus {
 ////////////////////////////////////////////////////////////////////////////////
 
 YT_DEFINE_GLOBAL(const NLogging::TLogger, BusLogger, "Bus");
-inline const NProfiling::TProfiler BusProfiler("/bus");
+YT_DEFINE_GLOBAL(const NProfiling::TProfiler, BusProfiler, "/bus");
 
 using TConnectionId = TGuid;
 using TPacketId = TGuid;
diff --git a/yt/yt/core/bus/tcp/dispatcher.cpp b/yt/yt/core/bus/tcp/dispatcher.cpp
@@ -10,7 +10,7 @@ namespace NYT::NBus {
 TTcpDispatcher::TTcpDispatcher()
     : Impl_(New<TImpl>())
 {
-    BusProfiler.WithSparse().AddProducer("", Impl_);
+    BusProfiler().WithSparse().AddProducer("", Impl_);
 }
 
 TTcpDispatcher* TTcpDispatcher::Get()
diff --git a/yt/yt/core/concurrency/delayed_executor.cpp b/yt/yt/core/concurrency/delayed_executor.cpp
@@ -239,10 +239,10 @@ class TDelayedExecutorImpl
         TActionQueuePtr DelayedQueue_;
         IInvokerPtr DelayedInvoker_;
 
-        NProfiling::TGauge ScheduledCallbacksGauge_ = ConcurrencyProfiler.Gauge("/delayed_executor/scheduled_callbacks");
-        NProfiling::TCounter SubmittedCallbacksCounter_ = ConcurrencyProfiler.Counter("/delayed_executor/submitted_callbacks");
-        NProfiling::TCounter CanceledCallbacksCounter_ = ConcurrencyProfiler.Counter("/delayed_executor/canceled_callbacks");
-        NProfiling::TCounter StaleCallbacksCounter_ = ConcurrencyProfiler.Counter("/delayed_executor/stale_callbacks");
+        NProfiling::TGauge ScheduledCallbacksGauge_ = ConcurrencyProfiler().Gauge("/delayed_executor/scheduled_callbacks");
+        NProfiling::TCounter SubmittedCallbacksCounter_ = ConcurrencyProfiler().Counter("/delayed_executor/submitted_callbacks");
+        NProfiling::TCounter CanceledCallbacksCounter_ = ConcurrencyProfiler().Counter("/delayed_executor/canceled_callbacks");
+        NProfiling::TCounter StaleCallbacksCounter_ = ConcurrencyProfiler().Counter("/delayed_executor/stale_callbacks");
 
         class TCallbackGuard
         {
diff --git a/yt/yt/core/concurrency/private.h b/yt/yt/core/concurrency/private.h
@@ -53,7 +53,7 @@ DECLARE_REFCOUNTED_STRUCT(IFairShareCallbackQueue)
 ////////////////////////////////////////////////////////////////////////////////
 
 YT_DEFINE_GLOBAL(const NLogging::TLogger, ConcurrencyLogger, "Concurrency");
-inline const NProfiling::TProfiler ConcurrencyProfiler("/concurrency");
+YT_DEFINE_GLOBAL(const NProfiling::TProfiler, ConcurrencyProfiler, "/concurrency");
 
 ////////////////////////////////////////////////////////////////////////////////
 
diff --git a/yt/yt/core/dns/ares_dns_resolver.cpp b/yt/yt/core/dns/ares_dns_resolver.cpp
@@ -180,7 +180,7 @@ class TAresDnsResolver
 private:
     const TAresDnsResolverConfigPtr Config_;
 
-    const NProfiling::TProfiler Profiler_ = DnsProfiler.WithPrefix("/ares_resolver");
+    const NProfiling::TProfiler Profiler_ = DnsProfiler().WithPrefix("/ares_resolver");
     const NProfiling::TCounter RequestCounter_ = Profiler_.Counter("/request_count");
     const NProfiling::TCounter FailureCounter_ = Profiler_.Counter("/failure_count");
     const NProfiling::TCounter TimeoutCounter_ = Profiler_.Counter("/timeout_count");
diff --git a/yt/yt/core/dns/private.h b/yt/yt/core/dns/private.h
@@ -11,7 +11,7 @@ namespace NYT::NDns {
 ////////////////////////////////////////////////////////////////////////////////
 
 YT_DEFINE_GLOBAL(const NLogging::TLogger, DnsLogger, "Dns");
-inline const NProfiling::TProfiler DnsProfiler("/dns");
+YT_DEFINE_GLOBAL(const NProfiling::TProfiler, DnsProfiler, "/dns");
 
 ////////////////////////////////////////////////////////////////////////////////
 
diff --git a/yt/yt/core/net/address.cpp b/yt/yt/core/net/address.cpp
@@ -987,7 +987,7 @@ class TAddressResolver::TImpl
         : TAsyncExpiringCache(
             config,
             /*logger*/ {},
-            DnsProfiler.WithPrefix("/resolve_cache"))
+            DnsProfiler().WithPrefix("/resolve_cache"))
     {
         Configure(std::move(config));
     }
diff --git a/yt/yt/core/rpc/channel_detail.cpp b/yt/yt/core/rpc/channel_detail.cpp
@@ -203,7 +203,7 @@ auto TClientRequestPerformanceProfiler::GetPerformanceCounters(
     using TCountersMap = NConcurrency::TSyncMap<std::pair<std::string, std::string>, TPerformanceCounters>;
 
     auto [counter, _] = LeakySingleton<TCountersMap>()->FindOrInsert(std::pair(service, method), [&] {
-        auto profiler = RpcClientProfiler
+        auto profiler = RpcClientProfiler()
             .WithHot()
             .WithTag("yt_service", service)
             .WithTag("method", method, -1);
diff --git a/yt/yt/core/rpc/grpc/private.h b/yt/yt/core/rpc/grpc/private.h
@@ -22,7 +22,7 @@ namespace NYT::NRpc::NGrpc {
 
 ////////////////////////////////////////////////////////////////////////////////
 
-inline const NProfiling::TProfiler GrpcServerProfiler("/grpc/server");
+YT_DEFINE_GLOBAL(const NProfiling::TProfiler, GrpcServerProfiler, "/grpc/server");
 
 ////////////////////////////////////////////////////////////////////////////////
 
diff --git a/yt/yt/core/rpc/grpc/server.cpp b/yt/yt/core/rpc/grpc/server.cpp
@@ -75,7 +75,7 @@ class TServer
             BIND_NO_PROPAGATE(&TServer::Shutdown, MakeWeak(this), /*graceful*/ true),
             /*priority*/ GrpcServerShutdownPriority))
         , LibraryLock_(TDispatcher::Get()->GetLibraryLock())
-        , Profiler_(GrpcServerProfiler.WithTag("name", Config_->ProfilingName))
+        , Profiler_(GrpcServerProfiler().WithTag("name", Config_->ProfilingName))
         , CompletionQueue_(TDispatcher::Get()->PickRandomGuardedCompletionQueue()->UnwrapUnsafe())
     {
         Profiler_.AddFuncGauge("/call_handler_count", MakeStrong(this), [this] {
diff --git a/yt/yt/core/rpc/private.h b/yt/yt/core/rpc/private.h
@@ -13,8 +13,8 @@ namespace NYT::NRpc {
 YT_DEFINE_GLOBAL(const NLogging::TLogger, RpcServerLogger, "RpcServer");
 YT_DEFINE_GLOBAL(const NLogging::TLogger, RpcClientLogger, "RpcClient");
 
-inline const NProfiling::TProfiler RpcServerProfiler("/rpc/server");
-inline const NProfiling::TProfiler RpcClientProfiler("/rpc/client");
+YT_DEFINE_GLOBAL(const NProfiling::TProfiler, RpcServerProfiler, "/rpc/server");
+YT_DEFINE_GLOBAL(const NProfiling::TProfiler, RpcClientProfiler, "/rpc/client");
 
 ////////////////////////////////////////////////////////////////////////////////
 
diff --git a/yt/yt/core/rpc/service_detail.cpp b/yt/yt/core/rpc/service_detail.cpp
@@ -1689,15 +1689,15 @@ TServiceBase::TServiceBase(
     , ServiceDescriptor_(descriptor)
     , ServiceId_(descriptor.FullServiceName, options.RealmId)
     , MemoryUsageTracker_(std::move(options.MemoryUsageTracker))
-    , Profiler_(RpcServerProfiler
+    , Profiler_(RpcServerProfiler()
         .WithHot(options.UseHotProfiler)
         .WithTag("yt_service", ServiceId_.ServiceName))
     , AuthenticationTimer_(Profiler_.Timer("/authentication_time"))
     , ServiceLivenessChecker_(New<TPeriodicExecutor>(
         TDispatcher::Get()->GetLightInvoker(),
         BIND(&TServiceBase::OnServiceLivenessCheck, MakeWeak(this)),
         ServiceLivenessCheckPeriod))
-    , PerformanceCounters_(New<TServiceBase::TPerformanceCounters>(RpcServerProfiler))
+    , PerformanceCounters_(New<TServiceBase::TPerformanceCounters>(RpcServerProfiler()))
     , UnknownMethodPerformanceCounters_(CreateUnknownMethodPerformanceCounters())
 {
     RegisterMethod(RPC_SERVICE_METHOD_DESC(Discover)

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ namespace NYT::NBus {`
`10`	`10`	`TTcpDispatcher::TTcpDispatcher()`
`11`	`11`	`: Impl_(New<TImpl>())`
`12`	`12`	`{`
`13`		`- BusProfiler.WithSparse().AddProducer("", Impl_);`
	`13`	`+ BusProfiler().WithSparse().AddProducer("", Impl_);`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`TTcpDispatcher* TTcpDispatcher::Get()`
Original file line number	Diff line number	Diff line change
`@@ -987,7 +987,7 @@ class TAddressResolver::TImpl`
`987`	`987`	`: TAsyncExpiringCache(`
`988`	`988`	`config,`
`989`	`989`	`/logger/ {},`
`990`		`- DnsProfiler.WithPrefix("/resolve_cache"))`
	`990`	`+ DnsProfiler().WithPrefix("/resolve_cache"))`
`991`	`991`	`{`
`992`	`992`	`Configure(std::move(config));`
`993`	`993`	`}`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ class TServer`
`75`	`75`	`BIND_NO_PROPAGATE(&TServer::Shutdown, MakeWeak(this), /graceful/ true),`
`76`	`76`	`/priority/ GrpcServerShutdownPriority))`
`77`	`77`	`, LibraryLock_(TDispatcher::Get()->GetLibraryLock())`
`78`		`- , Profiler_(GrpcServerProfiler.WithTag("name", Config_->ProfilingName))`
	`78`	`+ , Profiler_(GrpcServerProfiler().WithTag("name", Config_->ProfilingName))`
`79`	`79`	`, CompletionQueue_(TDispatcher::Get()->PickRandomGuardedCompletionQueue()->UnwrapUnsafe())`
`80`	`80`	`{`
`81`	`81`	`Profiler_.AddFuncGauge("/call_handler_count", MakeStrong(this), [this] {`