Skip to content

Commit 1faa700

Browse files
authored
Use topic api in pq_async_io tests (#6156)
1 parent d9828e0 commit 1faa700

File tree

3 files changed

+22
-27
lines changed

3 files changed

+22
-27
lines changed

ydb/tests/fq/pq_async_io/ut_helpers.cpp

Lines changed: 20 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -148,12 +148,12 @@ void PQWrite(
148148
cfg.SetDatabase(GetDefaultPqDatabase());
149149
cfg.SetLog(CreateLogBackend("cerr"));
150150
NYdb::TDriver driver(cfg);
151-
NYdb::NPersQueue::TPersQueueClient client(driver);
152-
NYdb::NPersQueue::TWriteSessionSettings sessionSettings;
151+
NYdb::NTopic::TTopicClient client(driver);
152+
NYdb::NTopic::TWriteSessionSettings sessionSettings;
153153
sessionSettings
154154
.Path(topic)
155155
.MessageGroupId("src_id")
156-
.Codec(NYdb::NPersQueue::ECodec::RAW);
156+
.Codec(NYdb::NTopic::ECodec::RAW);
157157
auto session = client.CreateSimpleBlockingWriteSession(sessionSettings);
158158
for (const TString& data : sequence) {
159159
UNIT_ASSERT_C(session->Write(data), "Failed to write message with body \"" << data << "\" to topic " << topic);
@@ -175,17 +175,16 @@ std::vector<TString> PQReadUntil(
175175
cfg.SetDatabase(GetDefaultPqDatabase());
176176
cfg.SetLog(CreateLogBackend("cerr"));
177177
NYdb::TDriver driver(cfg);
178-
NYdb::NPersQueue::TPersQueueClient client(driver);
179-
NYdb::NPersQueue::TReadSessionSettings sessionSettings;
178+
NYdb::NTopic::TTopicClient client(driver);
179+
NYdb::NTopic::TReadSessionSettings sessionSettings;
180180
sessionSettings
181181
.AppendTopics(topic)
182-
.ConsumerName(DefaultPqConsumer)
183-
.DisableClusterDiscovery(true);
182+
.ConsumerName(DefaultPqConsumer);
184183

185184
auto promise = NThreading::NewPromise();
186185
std::vector<TString> result;
187186

188-
sessionSettings.EventHandlers_.SimpleDataHandlers([&](NYdb::NPersQueue::TReadSessionEvent::TDataReceivedEvent& ev) {
187+
sessionSettings.EventHandlers_.SimpleDataHandlers([&](NYdb::NTopic::TReadSessionEvent::TDataReceivedEvent& ev) {
189188
for (const auto& message : ev.GetMessages()) {
190189
result.emplace_back(message.GetData());
191190
}
@@ -194,7 +193,7 @@ std::vector<TString> PQReadUntil(
194193
}
195194
}, false, false);
196195

197-
std::shared_ptr<NYdb::NPersQueue::IReadSession> session = client.CreateReadSession(sessionSettings);
196+
std::shared_ptr<NYdb::NTopic::IReadSession> session = client.CreateReadSession(sessionSettings);
198197
UNIT_ASSERT(promise.GetFuture().Wait(timeout));
199198
session->Close(TDuration::Zero());
200199
session = nullptr;
@@ -224,20 +223,18 @@ void PQCreateStream(const TString& streamName)
224223
}
225224

226225
void AddReadRule(NYdb::TDriver& driver, const TString& streamName) {
227-
NYdb::NPersQueue::TPersQueueClient client(driver);
228-
229-
auto result = client.AddReadRule(
230-
streamName,
231-
NYdb::NPersQueue::TAddReadRuleSettings()
232-
.ReadRule(
233-
NYdb::NPersQueue::TReadRuleSettings()
234-
.ConsumerName(DefaultPqConsumer)
235-
.ServiceType("yandex-query")
236-
.SupportedCodecs({
237-
NYdb::NPersQueue::ECodec::RAW
238-
})
239-
)
240-
).ExtractValueSync();
226+
NYdb::NTopic::TTopicClient client(driver);
227+
228+
auto alterTopicSettings =
229+
NYdb::NTopic::TAlterTopicSettings()
230+
.BeginAddConsumer(DefaultPqConsumer)
231+
.SetSupportedCodecs(
232+
{
233+
NYdb::NTopic::ECodec::RAW
234+
})
235+
.EndAddConsumer();
236+
auto result = client.AlterTopic(streamName, alterTopicSettings).ExtractValueSync();
237+
241238
UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), NYdb::EStatus::SUCCESS, result.GetIssues().ToString());
242239
UNIT_ASSERT_VALUES_EQUAL(result.IsTransportError(), false);
243240
}

ydb/tests/fq/pq_async_io/ut_helpers.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
#include <ydb/library/yql/dq/actors/protos/dq_events.pb.h>
1010
#include <ydb/library/yql/minikql/mkql_alloc.h>
1111

12-
#include <ydb/public/sdk/cpp/client/ydb_persqueue_public/persqueue.h>
13-
#include <ydb/public/sdk/cpp/client/ydb_datastreams/datastreams.h>
12+
#include <ydb/public/sdk/cpp/client/ydb_topic/topic.h>
1413
#include <ydb/core/testlib/basics/runtime.h>
1514

1615
#include <library/cpp/testing/unittest/registar.h>

ydb/tests/fq/pq_async_io/ya.make

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ SRCS(
77
PEERDIR(
88
ydb/library/yql/minikql/computation/llvm14
99
ydb/library/yql/providers/common/ut_helpers
10-
ydb/public/sdk/cpp/client/ydb_datastreams
11-
ydb/public/sdk/cpp/client/ydb_persqueue_public
10+
ydb/public/sdk/cpp/client/ydb_topic
1211
)
1312

1413
YQL_LAST_ABI_VERSION()

0 commit comments

Comments
 (0)