Skip to content

Commit 1e55f85

Browse files
authored
Change TODO comments about pg types in minikql (#11651)
1 parent 4a0b2a7 commit 1e55f85

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

ydb/core/client/minikql_compile/yql_expr_minikql.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ class TKikimrCallableTypeAnnotationTransformer : public TSyncTransformerBase {
397397

398398
switch (column->Type.GetTypeId()) {
399399
case NScheme::NTypeIds::Pg: {
400-
// TODO: support pg types
400+
// no need to support pg types in the deprecated minikql engine
401401
YQL_ENSURE(false, "pg types are not supported");
402402
break;
403403
}

ydb/core/engine/kikimr_program_builder.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ TType* ValidateColumns(
2323
rowTypeBuilder.Reserve(columns.size());
2424
tagsBuilder.Reserve(columns.size());
2525
for (auto& col : columns) {
26-
// TODO: support pg types
26+
// no need to support pg types in the deprecated minikql engine
2727
MKQL_ENSURE(col.SchemeType.GetTypeId() != 0, "Null type is not allowed");
2828
MKQL_ENSURE(col.SchemeType.GetTypeId() != NScheme::NTypeIds::Pg, "pg types are not supported");
2929
TType* dataType;
@@ -108,7 +108,7 @@ void TUpdateRowBuilder::SetColumn(
108108
ui32 columnId, NScheme::TTypeInfo expectedType,
109109
TRuntimeNode value)
110110
{
111-
// TODO: support pg types
111+
// no need to support pg types in the deprecated minikql engine
112112
MKQL_ENSURE(expectedType.GetTypeId() != NScheme::NTypeIds::Pg, "pg types are not supported");
113113

114114
bool isOptional;
@@ -126,7 +126,7 @@ void TUpdateRowBuilder::InplaceUpdateColumn(
126126
TRuntimeNode value,
127127
EInplaceUpdateMode mode)
128128
{
129-
// TODO: support pg types
129+
// no need to support pg types in the deprecated minikql engine
130130
MKQL_ENSURE(expectedType.GetTypeId() != NScheme::NTypeIds::Pg, "pg types are not supported");
131131
MKQL_ENSURE(AS_TYPE(TDataType, value)->GetSchemeType() == expectedType.GetTypeId(),
132132
"Mismatch of column type");
@@ -214,7 +214,7 @@ TVector<TRuntimeNode> TKikimrProgramBuilder::FixKeysType(
214214
MKQL_ENSURE(keyTypes.size() == row.size(), "Mismatch of key types count");
215215
TVector<TRuntimeNode> tmp(row.size());
216216
for (ui32 i = 0; i < row.size(); ++i) {
217-
// TODO: support pg types
217+
// no need to support pg types in the deprecated minikql engine
218218
MKQL_ENSURE(keyTypes[i].GetTypeId() != NScheme::NTypeIds::Pg, "pg types are not supported");
219219
tmp[i] = RewriteNullType(row[i], keyTypes[i].GetTypeId());
220220
bool isOptional;

ydb/core/engine/minikql/minikql_engine_host.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ class TSelectRangeLazyRowsList : public TCustomListValue {
498498
}
499499
firstKey.AppendNoAlias((const char*)typeIds.data(), tuple.ColumnCount * sizeof(NScheme::TTypeId));
500500
firstKey.AppendNoAlias(cells);
501-
// TODO: support pg types
501+
// no need to support pg types in the deprecated minikql engine
502502

503503
if (List.FirstKey) {
504504
Y_DEBUG_ABORT_UNLESS(*List.FirstKey == firstKey);

ydb/core/engine/mkql_engine_flat_extfunc.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ namespace {
2828
}
2929

3030
const auto literal = AS_VALUE(TDataLiteral, data);
31-
// TODO: support pg types
31+
// no need to support pg types in the deprecated minikql engine
3232
auto typeInfo = NScheme::TTypeInfo(literal->GetType()->GetSchemeType());
3333
return MakeCell(typeInfo, literal->AsValue(), env, false);
3434
}
@@ -638,14 +638,14 @@ namespace {
638638
keyColumnsCount = partKeyColumnsCount;
639639
for (ui32 i = 0; i < partKeyColumnsCount; ++i) {
640640
auto partType = ReadUnaligned<NUdf::TDataTypeId>(partTypes + i * sizeof(NUdf::TDataTypeId));
641-
// TODO: support pg types
641+
// no need to support pg types in the deprecated minikql engine
642642
types.push_back(NScheme::TTypeInfo(partType));
643643
}
644644
} else {
645645
MKQL_ENSURE(keyColumnsCount == partKeyColumnsCount, "Mismatch of key columns count");
646646
for (ui32 i = 0; i < keyColumnsCount; ++i) {
647647
auto partType = ReadUnaligned<NUdf::TDataTypeId>(partTypes + i * sizeof(NUdf::TDataTypeId));
648-
// TODO: support pg types
648+
// no need to support pg types in the deprecated minikql engine
649649
MKQL_ENSURE(partType == types[i].GetTypeId(), "Mismatch of key columns type");
650650
}
651651
}

0 commit comments

Comments
 (0)