Skip to content

Commit 1d06b7d

Browse files
committed
Fixed issues
1 parent 20aa3ad commit 1d06b7d

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

ydb/core/kqp/executer_actor/kqp_executer_impl.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1727,9 +1727,7 @@ class TKqpExecuterBase : public TActorBootstrapped<TDerived> {
17271727
}
17281728

17291729
ResponseEv->Record.MutableResponse()->SetStatus(Ydb::StatusIds::TIMEOUT);
1730-
for (const auto& issue : issues) {
1731-
NYql::IssueToMessage(issue, ResponseEv->Record.MutableResponse()->AddIssues());
1732-
}
1730+
NYql::IssuesToMessage(issues, ResponseEv->Record.MutableResponse()->MutableIssues());
17331731

17341732
// TEvAbortExecution can come from either ComputeActor or SessionActor (== Target).
17351733
if (abortSender != Target) {

ydb/core/kqp/proxy_service/kqp_proxy_service.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1286,8 +1286,8 @@ class TKqpProxyService : public TActorBootstrapped<TKqpProxyService> {
12861286
const TKqpSessionInfo* info = LocalSessions->FindPtr(reqInfo->SessionId);
12871287
if (msg->Round == 0 && info) {
12881288
TString message = msg->Status == NYql::NDqProto::StatusIds::TIMEOUT
1289-
? (TStringBuilder() << "Request's timeout " << msg->Timeout.MilliSeconds() << "ms exceeded")
1290-
: (TStringBuilder() << "Request's canceled after " << msg->Timeout.MilliSeconds() << "ms");
1289+
? (TStringBuilder() << "Request timeout " << msg->Timeout.MilliSeconds() << "ms exceeded")
1290+
: (TStringBuilder() << "Request canceled after " << msg->Timeout.MilliSeconds() << "ms");
12911291

12921292
Send(info->WorkerId, new TEvKqp::TEvAbortExecution(msg->Status, message));
12931293

ydb/core/kqp/run_script_actor/kqp_run_script_actor.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include <ydb/library/ydb_issue/issue_helpers.h>
44
#include <ydb/core/kqp/common/events/events.h>
55
#include <ydb/core/kqp/common/kqp.h>
6+
#include <ydb/core/kqp/common/kqp_timeouts.h>
67
#include <ydb/core/kqp/executer_actor/kqp_executer.h>
78
#include <ydb/core/kqp/proxy_service/kqp_script_executions.h>
89
#include <ydb/core/kqp/proxy_service/proto/result_set_meta.pb.h>
@@ -219,6 +220,7 @@ class TRunScriptActor : public NActors::TActorBootstrapped<TRunScriptActor> {
219220
if (RunState == ERunState::Cancelling) {
220221
NYql::TIssue cancelIssue("Request was canceled by user");
221222
cancelIssue.SetCode(NYql::DEFAULT_ERROR, NYql::TSeverityIds::S_INFO);
223+
Issues.AddIssue(std::move(cancelIssue));
222224
}
223225

224226
auto scriptFinalizeRequest = std::make_unique<TEvScriptFinalizeRequest>(
@@ -429,6 +431,13 @@ class TRunScriptActor : public NActors::TActorBootstrapped<TRunScriptActor> {
429431
const auto& issueMessage = record.GetResponse().GetQueryIssues();
430432
NYql::IssuesFromMessage(issueMessage, Issues);
431433

434+
if (record.GetYdbStatus() == Ydb::StatusIds::TIMEOUT) {
435+
const TDuration timeout = GetQueryTimeout(NKikimrKqp::QUERY_TYPE_SQL_GENERIC_SCRIPT, Request.GetRequest().GetTimeoutMs(), {}, QueryServiceConfig);
436+
NYql::TIssue timeoutIssue(TStringBuilder() << "Current request timeout is " << timeout.MilliSeconds() << "ms");
437+
timeoutIssue.SetCode(NYql::DEFAULT_ERROR, NYql::TSeverityIds::S_INFO);
438+
Issues.AddIssue(std::move(timeoutIssue));
439+
}
440+
432441
if (record.GetResponse().HasQueryPlan()) {
433442
QueryPlan = record.GetResponse().GetQueryPlan();
434443
}

0 commit comments

Comments
 (0)