Skip to content

Commit 17fe316

Browse files
Enjectionblinkov
authored andcommitted
Fix sdk according review in #14617 (#14831)
1 parent dd8f422 commit 17fe316

File tree

10 files changed

+41
-368
lines changed

10 files changed

+41
-368
lines changed

ydb/public/lib/ydb_cli/commands/ydb_dynamic_config.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ int TCommandConfigReplace::Run(TConfig& config) {
215215

216216
auto status = client.ReplaceConfig(DynamicConfig, settings).GetValueSync();
217217

218-
if (status.IsUnimplementedError()) {
218+
if (status.GetStatus() == EStatus::CLIENT_CALL_UNIMPLEMENTED) {
219219
Cerr << "Warning: Fallback to DynamicConfig API" << Endl;
220220

221221
auto client = NYdb::NDynamicConfig::TDynamicConfigClient(*driver);

ydb/public/sdk/cpp/client/ydb_config/ya.make

Lines changed: 0 additions & 14 deletions
This file was deleted.

ydb/public/sdk/cpp/client/ydb_config/ydb_config.cpp

Lines changed: 0 additions & 182 deletions
This file was deleted.

ydb/public/sdk/cpp/client/ydb_config/ydb_config.h

Lines changed: 0 additions & 124 deletions
This file was deleted.

ydb/public/sdk/cpp/client/ydb_types/status/status.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,6 @@ void TStatus::CheckStatusOk(const TStringType& str) const {
5656
Impl_->CheckStatusOk(str);
5757
}
5858

59-
bool TStatus::IsUnimplementedError() const {
60-
return Impl_->Status.Status == EStatus::CLIENT_CALL_UNIMPLEMENTED;
61-
}
62-
6359
void TStatus::RaiseError(const TStringType& str) const {
6460
Impl_->RaiseError(str);
6561
}

ydb/public/sdk/cpp/client/ydb_types/status/status.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ class TStatus {
2626
const NYql::TIssues& GetIssues() const;
2727
bool IsSuccess() const;
2828
bool IsTransportError() const;
29-
bool IsUnimplementedError() const;
3029
const TStringType& GetEndpoint() const;
3130
const std::multimap<TStringType, TStringType>& GetResponseMetadata() const;
3231
float GetConsumedRu() const;

0 commit comments

Comments
 (0)