Rename TSignature(Generator,Validator)Base -> ISignature(Generator,Validator)

p4vook · blinkov · commit 1521099c9e74 · 2025-03-21T09:51:58.000+07:00
commit_hash:c4cc1b2689828719c2911f99f0e97c69316de6e6
diff --git a/yt/yt/client/driver/driver.cpp b/yt/yt/client/driver/driver.cpp
@@ -115,8 +115,8 @@ class TDriver
     TDriver(
         TDriverConfigPtr config,
         IConnectionPtr connection,
-        TSignatureGeneratorBasePtr signatureGenerator,
-        TSignatureValidatorBasePtr signatureValidator)
+        ISignatureGeneratorPtr signatureGenerator,
+        ISignatureValidatorPtr signatureValidator)
         : Config_(std::move(config))
         , Connection_(std::move(connection))
         , ClientCache_(New<TClientCache>(Config_->ClientCache, Connection_))
@@ -502,12 +502,12 @@ class TDriver
         return Connection_;
     }
 
-    TSignatureGeneratorBasePtr GetSignatureGenerator() override
+    ISignatureGeneratorPtr GetSignatureGenerator() override
     {
         return SignatureGenerator_;
     }
 
-    TSignatureValidatorBasePtr GetSignatureValidator() override
+    ISignatureValidatorPtr GetSignatureValidator() override
     {
         return SignatureValidator_;
     }
@@ -535,8 +535,8 @@ class TDriver
     TClientCachePtr ClientCache_;
     const IClientPtr RootClient_;
     IProxyDiscoveryCachePtr ProxyDiscoveryCache_;
-    TSignatureGeneratorBasePtr SignatureGenerator_;
-    TSignatureValidatorBasePtr SignatureValidator_;
+    ISignatureGeneratorPtr SignatureGenerator_;
+    ISignatureValidatorPtr SignatureValidator_;
 
     class TCommandContext;
     using TCommandContextPtr = TIntrusivePtr<TCommandContext>;
@@ -730,8 +730,8 @@ class TDriver
 IDriverPtr CreateDriver(
     IConnectionPtr connection,
     TDriverConfigPtr config,
-    TSignatureGeneratorBasePtr signatureGenerator,
-    TSignatureValidatorBasePtr signatureValidator)
+    ISignatureGeneratorPtr signatureGenerator,
+    ISignatureValidatorPtr signatureValidator)
 {
     YT_VERIFY(connection);
     YT_VERIFY(config);
diff --git a/yt/yt/client/driver/driver.h b/yt/yt/client/driver/driver.h
@@ -152,9 +152,9 @@ struct IDriver
     //! Returns the underlying connection.
     virtual NApi::IConnectionPtr GetConnection() = 0;
 
-    virtual NSignature::TSignatureGeneratorBasePtr GetSignatureGenerator() = 0;
+    virtual NSignature::ISignatureGeneratorPtr GetSignatureGenerator() = 0;
 
-    virtual NSignature::TSignatureValidatorBasePtr GetSignatureValidator() = 0;
+    virtual NSignature::ISignatureValidatorPtr GetSignatureValidator() = 0;
 
     //! Terminates the underlying connection.
     virtual void Terminate() = 0;
@@ -167,8 +167,8 @@ DEFINE_REFCOUNTED_TYPE(IDriver)
 IDriverPtr CreateDriver(
     NApi::IConnectionPtr connection,
     TDriverConfigPtr config,
-    NSignature::TSignatureGeneratorBasePtr signatureGenerator,
-    NSignature::TSignatureValidatorBasePtr signatureValidator);
+    NSignature::ISignatureGeneratorPtr signatureGenerator,
+    NSignature::ISignatureValidatorPtr signatureValidator);
 
 ////////////////////////////////////////////////////////////////////////////////
 
diff --git a/yt/yt/client/signature/generator.cpp b/yt/yt/client/signature/generator.cpp
@@ -10,7 +10,7 @@ using namespace NYson;
 
 ////////////////////////////////////////////////////////////////////////////////
 
-TSignaturePtr TSignatureGeneratorBase::Sign(TYsonString data)
+TSignaturePtr ISignatureGenerator::Sign(TYsonString data)
 {
     auto signature = New<TSignature>();
     signature->Payload_ = std::move(data);
@@ -21,7 +21,7 @@ TSignaturePtr TSignatureGeneratorBase::Sign(TYsonString data)
 ////////////////////////////////////////////////////////////////////////////////
 
 class TDummySignatureGenerator
-    : public TSignatureGeneratorBase
+    : public ISignatureGenerator
 {
 public:
     void Sign(const TSignaturePtr& signature) override
@@ -30,15 +30,15 @@ class TDummySignatureGenerator
     }
 };
 
-TSignatureGeneratorBasePtr CreateDummySignatureGenerator()
+ISignatureGeneratorPtr CreateDummySignatureGenerator()
 {
     return New<TDummySignatureGenerator>();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 class TAlwaysThrowingSignatureGenerator
-    : public TSignatureGeneratorBase
+    : public ISignatureGenerator
 {
 public:
     void Sign(const TSignaturePtr& /*signature*/) override
@@ -47,7 +47,7 @@ class TAlwaysThrowingSignatureGenerator
     }
 };
 
-TSignatureGeneratorBasePtr CreateAlwaysThrowingSignatureGenerator()
+ISignatureGeneratorPtr CreateAlwaysThrowingSignatureGenerator()
 {
     return New<TAlwaysThrowingSignatureGenerator>();
 }
diff --git a/yt/yt/client/signature/generator.h b/yt/yt/client/signature/generator.h
@@ -8,7 +8,7 @@ namespace NYT::NSignature {
 
 ////////////////////////////////////////////////////////////////////////////////
 
-class TSignatureGeneratorBase
+class ISignatureGenerator
     : public TRefCounted
 {
 public:
@@ -24,13 +24,13 @@ class TSignatureGeneratorBase
     friend class TAlwaysThrowingSignatureGenerator;
 };
 
-DEFINE_REFCOUNTED_TYPE(TSignatureGeneratorBase)
+DEFINE_REFCOUNTED_TYPE(ISignatureGenerator)
 
 ////////////////////////////////////////////////////////////////////////////////
 
-TSignatureGeneratorBasePtr CreateDummySignatureGenerator();
+ISignatureGeneratorPtr CreateDummySignatureGenerator();
 
-TSignatureGeneratorBasePtr CreateAlwaysThrowingSignatureGenerator();
+ISignatureGeneratorPtr CreateAlwaysThrowingSignatureGenerator();
 
 ////////////////////////////////////////////////////////////////////////////////
 
diff --git a/yt/yt/client/signature/public.h b/yt/yt/client/signature/public.h
@@ -10,8 +10,8 @@ DECLARE_REFCOUNTED_CLASS(TSignature)
 
 ///////////////////////////////////////////////////////////////////////////////
 
-DECLARE_REFCOUNTED_CLASS(TSignatureGeneratorBase)
-DECLARE_REFCOUNTED_CLASS(TSignatureValidatorBase)
+DECLARE_REFCOUNTED_CLASS(ISignatureGenerator)
+DECLARE_REFCOUNTED_CLASS(ISignatureValidator)
 
 ///////////////////////////////////////////////////////////////////////////////
 
diff --git a/yt/yt/client/signature/signature.h b/yt/yt/client/signature/signature.h
@@ -27,12 +27,12 @@ class TSignature final
     NYson::TYsonString Payload_;
     std::vector<std::byte> Signature_;
 
-    friend class TSignatureGeneratorBase;
+    friend class ISignatureGenerator;
     friend class TSignatureGenerator;
     friend class TDummySignatureGenerator;
     friend class TAlwaysThrowingSignatureGenerator;
 
-    friend class TSignatureValidatorBase;
+    friend class ISignatureValidator;
     friend class TSignatureValidator;
     friend class TDummySignatureValidator;
     friend class TAlwaysThrowingSignatureValidator;
diff --git a/yt/yt/client/signature/validator.cpp b/yt/yt/client/signature/validator.cpp
@@ -9,7 +9,7 @@ namespace NYT::NSignature {
 ////////////////////////////////////////////////////////////////////////////////
 
 class TDummySignatureValidator
-    : public TSignatureValidatorBase
+    : public ISignatureValidator
 {
 public:
     TFuture<bool> Validate(const TSignaturePtr& signature) override
@@ -19,15 +19,15 @@ class TDummySignatureValidator
     }
 };
 
-TSignatureValidatorBasePtr CreateDummySignatureValidator()
+ISignatureValidatorPtr CreateDummySignatureValidator()
 {
     return New<TDummySignatureValidator>();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 class TAlwaysThrowingSignatureValidator
-    : public TSignatureValidatorBase
+    : public ISignatureValidator
 {
 public:
     TFuture<bool> Validate(const TSignaturePtr& /*signature*/) override
@@ -36,7 +36,7 @@ class TAlwaysThrowingSignatureValidator
     }
 };
 
-TSignatureValidatorBasePtr CreateAlwaysThrowingSignatureValidator()
+ISignatureValidatorPtr CreateAlwaysThrowingSignatureValidator()
 {
     return New<TAlwaysThrowingSignatureValidator>();
 }
diff --git a/yt/yt/client/signature/validator.h b/yt/yt/client/signature/validator.h
@@ -10,20 +10,20 @@ namespace NYT::NSignature {
 
 ////////////////////////////////////////////////////////////////////////////////
 
-class TSignatureValidatorBase
+class ISignatureValidator
     : public TRefCounted
 {
 public:
     virtual TFuture<bool> Validate(const TSignaturePtr& signature) = 0;
 };
 
-DEFINE_REFCOUNTED_TYPE(TSignatureValidatorBase)
+DEFINE_REFCOUNTED_TYPE(ISignatureValidator)
 
 ////////////////////////////////////////////////////////////////////////////////
 
-TSignatureValidatorBasePtr CreateDummySignatureValidator();
+ISignatureValidatorPtr CreateDummySignatureValidator();
 
-TSignatureValidatorBasePtr CreateAlwaysThrowingSignatureValidator();
+ISignatureValidatorPtr CreateAlwaysThrowingSignatureValidator();
 
 ////////////////////////////////////////////////////////////////////////////////
 

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ using namespace NYson;`
`10`	`10`
`11`	`11`	`////////////////////////////////////////////////////////////////////////////////`
`12`	`12`
`13`		`-TSignaturePtr TSignatureGeneratorBase::Sign(TYsonString data)`
	`13`	`+TSignaturePtr ISignatureGenerator::Sign(TYsonString data)`
`14`	`14`	`{`
`15`	`15`	`auto signature = New<TSignature>();`
`16`	`16`	`signature->Payload_ = std::move(data);`
`@@ -21,7 +21,7 @@ TSignaturePtr TSignatureGeneratorBase::Sign(TYsonString data)`
`21`	`21`	`////////////////////////////////////////////////////////////////////////////////`
`22`	`22`
`23`	`23`	`class TDummySignatureGenerator`
`24`		`- : public TSignatureGeneratorBase`
	`24`	`+ : public ISignatureGenerator`
`25`	`25`	`{`
`26`	`26`	`public:`
`27`	`27`	`void Sign(const TSignaturePtr& signature) override`
`@@ -30,15 +30,15 @@ class TDummySignatureGenerator`
`30`	`30`	`}`
`31`	`31`	`};`
`32`	`32`
`33`		`-TSignatureGeneratorBasePtr CreateDummySignatureGenerator()`
	`33`	`+ISignatureGeneratorPtr CreateDummySignatureGenerator()`
`34`	`34`	`{`
`35`	`35`	`return New<TDummySignatureGenerator>();`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`////////////////////////////////////////////////////////////////////////////////`
`39`	`39`
`40`	`40`	`class TAlwaysThrowingSignatureGenerator`
`41`		`- : public TSignatureGeneratorBase`
	`41`	`+ : public ISignatureGenerator`
`42`	`42`	`{`
`43`	`43`	`public:`
`44`	`44`	`void Sign(const TSignaturePtr& /signature/) override`
`@@ -47,7 +47,7 @@ class TAlwaysThrowingSignatureGenerator`
`47`	`47`	`}`
`48`	`48`	`};`
`49`	`49`
`50`		`-TSignatureGeneratorBasePtr CreateAlwaysThrowingSignatureGenerator()`
	`50`	`+ISignatureGeneratorPtr CreateAlwaysThrowingSignatureGenerator()`
`51`	`51`	`{`
`52`	`52`	`return New<TAlwaysThrowingSignatureGenerator>();`
`53`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ namespace NYT::NSignature {`
`9`	`9`	`////////////////////////////////////////////////////////////////////////////////`
`10`	`10`
`11`	`11`	`class TDummySignatureValidator`
`12`		`- : public TSignatureValidatorBase`
	`12`	`+ : public ISignatureValidator`
`13`	`13`	`{`
`14`	`14`	`public:`
`15`	`15`	`TFuture<bool> Validate(const TSignaturePtr& signature) override`
`@@ -19,15 +19,15 @@ class TDummySignatureValidator`
`19`	`19`	`}`
`20`	`20`	`};`
`21`	`21`
`22`		`-TSignatureValidatorBasePtr CreateDummySignatureValidator()`
	`22`	`+ISignatureValidatorPtr CreateDummySignatureValidator()`
`23`	`23`	`{`
`24`	`24`	`return New<TDummySignatureValidator>();`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`////////////////////////////////////////////////////////////////////////////////`
`28`	`28`
`29`	`29`	`class TAlwaysThrowingSignatureValidator`
`30`		`- : public TSignatureValidatorBase`
	`30`	`+ : public ISignatureValidator`
`31`	`31`	`{`
`32`	`32`	`public:`
`33`	`33`	`TFuture<bool> Validate(const TSignaturePtr& /signature/) override`
`@@ -36,7 +36,7 @@ class TAlwaysThrowingSignatureValidator`
`36`	`36`	`}`
`37`	`37`	`};`
`38`	`38`
`39`		`-TSignatureValidatorBasePtr CreateAlwaysThrowingSignatureValidator()`
	`39`	`+ISignatureValidatorPtr CreateAlwaysThrowingSignatureValidator()`
`40`	`40`	`{`
`41`	`41`	`return New<TAlwaysThrowingSignatureValidator>();`
`42`	`42`	`}`