Fix wrong order of columns for transfer data from topic to column table (#14887)

Author: nshestakov

ydb/core/tx/replication/service/transfer_writer.cpp

@@ -236,27 +236,32 @@ TScheme BuildScheme(const TAutoPtr<NSchemeCache::TSchemeCacheNavigate>& nav) {
     });
 
     result.TableColumns.resize(keyColumns);
-    result.ColumnsMetadata.resize(keyColumns);
 
     for (const auto& [_, column] : entry.Columns) {
-        NKikimrKqp::TKqpColumnMetadataProto* c;
         if (column.KeyOrder >= 0) {
             result.TableColumns[column.KeyOrder] = {column.Name, column.Id, column.PType, column.KeyOrder >= 0, !column.IsNotNullColumn};
-            c = &result.ColumnsMetadata[column.KeyOrder];
         } else {
             result.TableColumns.emplace_back(column.Name, column.Id, column.PType, column.KeyOrder >= 0, !column.IsNotNullColumn);
-            result.ColumnsMetadata.emplace_back();
-            c = &result.ColumnsMetadata.back();
         }
+    }
+
+    std::map<TString, TSysTables::TTableColumnInfo> columns;
+    for (const auto& [_, column] : entry.Columns) {
+        columns[column.Name] = column;
+    }
 
-        result.WriteIndex.push_back(result.WriteIndex.size());
+    size_t i = keyColumns;
+    for (const auto& [_, column] : columns) {
+        result.ColumnsMetadata.emplace_back();
+        auto& c = result.ColumnsMetadata.back();
+        result.WriteIndex.push_back(column.KeyOrder >= 0 ? column.KeyOrder : i++);
 
-        c->SetName(column.Name);
-        c->SetId(column.Id);
-        c->SetTypeId(column.PType.GetTypeId());
+        c.SetName(column.Name);
+        c.SetId(column.Id);
+        c.SetTypeId(column.PType.GetTypeId());
 
         if (NScheme::NTypeIds::IsParametrizedType(column.PType.GetTypeId())) {
-            NScheme::ProtoFromTypeInfo(column.PType, "", *c->MutableTypeInfo());
+            NScheme::ProtoFromTypeInfo(column.PType, "", *c.MutableTypeInfo());
         }
     }