Statistics: disable datashard traversal (#8402)

Author: azevaykin

ydb/core/statistics/aggregator/aggregator_impl.cpp

@@ -550,6 +550,9 @@ void TStatisticsAggregator::Resolve() {
 }
 
 void TStatisticsAggregator::ScanNextDatashardRange() {
+    // Datashard traversal is temporary disabled
+    Y_FAIL();
+
     if (DatashardRanges.empty()) {
         SaveStatisticsToTable();
         return;
@@ -699,13 +702,21 @@ void TStatisticsAggregator::ScheduleNextTraversal(NIceDb::TNiceDb& db) {
     }
 
     TraversalPathId = pathId;
+    TraversalStartTime = TInstant::Now();
 
     std::optional<bool> isColumnTable = IsColumnTable(pathId);
     if (!isColumnTable){
         DeleteStatisticsFromTable();
         return;
     }
 
+    // Datashard traversal is temporary disabled
+    if (!*isColumnTable) {
+        SA_LOG_D("[" << TabletID() << "] ScheduleNextTraversal. Skip traversal for datashard table " << pathId);
+        DeleteStatisticsFromTable();
+        return;
+    }
+
     TraversalIsColumnTable = *isColumnTable;
 
     SA_LOG_D("[" << TabletID() << "] Start " 
@@ -716,7 +727,6 @@ void TStatisticsAggregator::ScheduleNextTraversal(NIceDb::TNiceDb& db) {
 }
 
 void TStatisticsAggregator::StartTraversal(NIceDb::TNiceDb& db) {
-    TraversalStartTime = TInstant::Now();
     PersistTraversal(db);
 
     TraversalStartKey = TSerializedCellVec();

ydb/core/statistics/aggregator/ut/ut_analyze_datashard.cpp

@@ -38,7 +38,7 @@ Y_UNIT_TEST_SUITE(AnalyzeDatashard) {
 
         Analyze(runtime, saTabletId, {{pathId}});
 
-        ValidateCountMinDatashard(runtime, pathId);
+        ValidateCountMinDatashardAbsense(runtime, pathId);
     }
 
     Y_UNIT_TEST(AnalyzeTwoTables) {
@@ -64,8 +64,8 @@ Y_UNIT_TEST_SUITE(AnalyzeDatashard) {
 
         Analyze(runtime, saTabletId1, {pathId1, pathId2});
 
-        ValidateCountMinDatashard(runtime, pathId1);
-        ValidateCountMinDatashard(runtime, pathId2);
+        ValidateCountMinDatashardAbsense(runtime, pathId1);
+        ValidateCountMinDatashardAbsense(runtime, pathId2);
     }
 
 

ydb/core/statistics/aggregator/ut/ut_traverse_datashard.cpp

@@ -34,7 +34,7 @@ Y_UNIT_TEST_SUITE(TraverseDatashard) {
         runtime.SimulateSleep(TDuration::Seconds(60));
 
         auto pathId = ResolvePathId(runtime, "/Root/Database/Table");
-        ValidateCountMinDatashard(runtime, pathId);
+        ValidateCountMinDatashardAbsense(runtime, pathId);
     }
 
     Y_UNIT_TEST(TraverseTwoTables) {
@@ -54,8 +54,8 @@ Y_UNIT_TEST_SUITE(TraverseDatashard) {
 
         auto pathId1 = ResolvePathId(runtime, "/Root/Database/Table1");
         auto pathId2 = ResolvePathId(runtime, "/Root/Database/Table2");
-        ValidateCountMinDatashard(runtime, pathId1);
-        ValidateCountMinDatashard(runtime, pathId2);
+        ValidateCountMinDatashardAbsense(runtime, pathId1);
+        ValidateCountMinDatashardAbsense(runtime, pathId2);
     }    
 
     Y_UNIT_TEST(TraverseOneTableServerless) {
@@ -85,7 +85,7 @@ Y_UNIT_TEST_SUITE(TraverseDatashard) {
         runtime.SimulateSleep(TDuration::Seconds(60));
 
         auto pathId = ResolvePathId(runtime, "/Root/Serverless/Table");
-        ValidateCountMinDatashard(runtime, pathId);
+        ValidateCountMinDatashardAbsense(runtime, pathId);
     }
 
     Y_UNIT_TEST(TraverseTwoTablesServerless) {
@@ -117,8 +117,8 @@ Y_UNIT_TEST_SUITE(TraverseDatashard) {
 
         auto pathId1 = ResolvePathId(runtime, "/Root/Serverless/Table1");
         auto pathId2 = ResolvePathId(runtime, "/Root/Serverless/Table2");
-        ValidateCountMinDatashard(runtime, pathId1);
-        ValidateCountMinDatashard(runtime, pathId2);
+        ValidateCountMinDatashardAbsense(runtime, pathId1);
+        ValidateCountMinDatashardAbsense(runtime, pathId2);
     }
 
     Y_UNIT_TEST(TraverseTwoTablesTwoServerlessDbs) {
@@ -151,8 +151,8 @@ Y_UNIT_TEST_SUITE(TraverseDatashard) {
 
         auto pathId1 = ResolvePathId(runtime, "/Root/Serverless1/Table1");
         auto pathId2 = ResolvePathId(runtime, "/Root/Serverless2/Table2");
-        ValidateCountMinDatashard(runtime, pathId1);
-        ValidateCountMinDatashard(runtime, pathId2);
+        ValidateCountMinDatashardAbsense(runtime, pathId1);
+        ValidateCountMinDatashardAbsense(runtime, pathId2);
     }
 
 }