Skip to content

Commit 0d8f95e

Browse files
authored
Sensor for number of shards within single BulkUpsert data (#11786)
1 parent 1b00f6a commit 0d8f95e

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

ydb/core/tx/data_events/shard_writer.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ class TCSUploadCounters: public NColumnShard::TCommonCountersOwner {
3939
NMonitoring::THistogramPtr FailedFullReplyDuration;
4040
NMonitoring::THistogramPtr BytesDistribution;
4141
NMonitoring::THistogramPtr RowsDistribution;
42+
NMonitoring::THistogramPtr ShardsCountDistribution;
4243
NMonitoring::TDynamicCounters::TCounterPtr RowsCount;
4344
NMonitoring::TDynamicCounters::TCounterPtr BytesCount;
4445
NMonitoring::TDynamicCounters::TCounterPtr FailsCount;
@@ -54,6 +55,7 @@ class TCSUploadCounters: public NColumnShard::TCommonCountersOwner {
5455
, FailedFullReplyDuration(TBase::GetHistogram("Replies/Failed/Full/DurationMs", NMonitoring::ExponentialHistogram(15, 2, 10)))
5556
, BytesDistribution(TBase::GetHistogram("Requests/Bytes", NMonitoring::ExponentialHistogram(15, 2, 1024)))
5657
, RowsDistribution(TBase::GetHistogram("Requests/Rows", NMonitoring::ExponentialHistogram(15, 2, 16)))
58+
, ShardsCountDistribution(TBase::GetHistogram("Requests/ShardSplits", NMonitoring::LinearHistogram(50, 1, 1)))
5759
, RowsCount(TBase::GetDeriviative("Rows"))
5860
, BytesCount(TBase::GetDeriviative("Bytes"))
5961
, FailsCount(TBase::GetDeriviative("Fails"))
@@ -81,6 +83,10 @@ class TCSUploadCounters: public NColumnShard::TCommonCountersOwner {
8183
FailsCount->Add(1);
8284
}
8385

86+
void OnSplitByShards(const ui64 shardsCount) const {
87+
ShardsCountDistribution->Collect(shardsCount);
88+
}
89+
8490
void OnCSReply(const TDuration d) const {
8591
CSReplyDuration->Collect(d.MilliSeconds());
8692
}

ydb/core/tx/tx_proxy/rpc_long_tx.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@ class TLongTxWriteBase: public TActorBootstrapped<TLongTxWriteImpl>,
9898
const auto& splittedData = shardsSplitter->GetSplitData();
9999
InternalController =
100100
std::make_shared<NEvWrite::TWritersController>(splittedData.GetShardRequestsCount(), this->SelfId(), LongTxId, NoTxWrite);
101+
102+
InternalController->GetCounters()->OnSplitByShards(splittedData.GetShardsCount());
101103
ui32 sumBytes = 0;
102104
ui32 rowsCount = 0;
103105
ui32 writeIdx = 0;

0 commit comments

Comments
 (0)