Always show table with tests (#7101)

Author: maximyurchuk

.github/actions/test_ya/action.yml

@@ -261,12 +261,6 @@ runs:
 
         for RETRY in $(seq 1 $TEST_RETRY_COUNT)
         do
-          if [ $RETRY = $TEST_RETRY_COUNT ]; then
-            IS_LAST_RETRY=1
-          else
-            IS_LAST_RETRY=0
-          fi
-
           if [ $RETRY != 1 ]; then
             IS_RETRY=1
           else
@@ -344,6 +338,22 @@ runs:
             "$CURRENT_JUNIT_XML_PATH"
           cp $CURRENT_JUNIT_XML_PATH $LAST_JUNIT_REPORT_XML
 
+          TESTS_RESULT=0
+          .github/scripts/tests/fail-checker.py "$CURRENT_JUNIT_XML_PATH" --output_path $CURRENT_PUBLIC_DIR/failed_count.txt || TESTS_RESULT=$?
+          FAILED_TESTS_COUNT=$(cat $CURRENT_PUBLIC_DIR/failed_count.txt)
+
+          IS_LAST_RETRY=0
+
+          if [ $TESTS_RESULT = 0 ] || [ $RETRY = $TEST_RETRY_COUNT ]; then
+            IS_LAST_RETRY=1
+          fi
+
+          if [ $FAILED_TESTS_COUNT -gt 500 ]; then 
+            IS_LAST_RETRY=1
+            TOO_MANY_FAILED="Too many tests failed, NOT going to retry"
+            echo $TOO_MANY_FAILED | GITHUB_TOKEN="${{ github.token }}" .github/scripts/tests/comment-pr.py --fail
+          fi
+
           if [ "${{ inputs.run_tests }}" = "true" ]; then
             GITHUB_TOKEN=${{ github.token }} .github/scripts/tests/generate-summary.py \
               --summary_links "$SUMMARY_LINKS" \
@@ -395,18 +405,7 @@ runs:
             echo "runid=" >> $GITHUB_OUTPUT
           fi
 
-          TESTS_RESULT=0
-          .github/scripts/tests/fail-checker.py "$CURRENT_JUNIT_XML_PATH" --output_path $CURRENT_PUBLIC_DIR/failed_count.txt || TESTS_RESULT=$?
-
-          FAILED_TESTS_COUNT=$(cat $CURRENT_PUBLIC_DIR/failed_count.txt)
-
-          if [ $FAILED_TESTS_COUNT -gt 500 ]; then 
-            TOO_MANY_FAILED="Too many tests failed, NOT going to retry"
-            echo $TOO_MANY_FAILED | GITHUB_TOKEN="${{ github.token }}" .github/scripts/tests/comment-pr.py --fail
-            break
-          fi
-
-          if [ $TESTS_RESULT = 0 ]; then
+          if [ $IS_LAST_RETRY = 1 ]; then
             break
           fi
         done;

.github/scripts/tests/generate-summary.py

@@ -152,10 +152,6 @@ def add_line(self, line: TestSummaryLine):
         self.is_failed |= line.is_failed
         self.lines.append(line)
 
-    @property
-    def is_empty(self):
-        return len(self.lines) == 0
-
     def render_line(self, items):
         return f"| {' | '.join(items)} |"
 
@@ -262,11 +258,8 @@ def write_summary(summary: TestSummary):
     else:
         fp = sys.stdout
 
-    if summary.is_empty:
-        fp.write(f"Test run completed, no test results found")
-    else:
-        for line in summary.render(add_footnote=True):
-            fp.write(f"{line}\n")
+    for line in summary.render(add_footnote=True):
+        fp.write(f"{line}\n")
 
     fp.write("\n")
 
@@ -283,9 +276,6 @@ def gen_summary(public_dir, public_dir_url, paths, is_retry: bool):
         for fn, suite, case in iter_xml_files(path):
             test_result = TestResult.from_junit(case)
             summary_line.add(test_result)
-
-        if not summary_line.tests:
-            continue
 
         if os.path.isabs(html_fn):
             html_fn = os.path.relpath(html_fn, public_dir)
@@ -300,12 +290,7 @@ def gen_summary(public_dir, public_dir_url, paths, is_retry: bool):
 
 def get_comment_text(pr: PullRequest, summary: TestSummary, summary_links: str, is_last_retry: bool)->tuple[str, list[str]]:
     color = "red"
-    if summary.is_empty:
-        color = "green"
-        return color, [
-            f"Test run completed, no test results found for commit {pr.head.sha}. "
-        ]
-    elif summary.is_failed:
+    if summary.is_failed:
         color = "red" if is_last_retry else "yellow"
         result = f"Some tests failed, follow the links below."
         if not is_last_retry: