Skip to content

Commit 0870583

Browse files
authored
Fix log priority and refactor switch in ProcessChunkWriteQueue (#9840)
1 parent c073323 commit 0870583

File tree

1 file changed

+14
-19
lines changed

1 file changed

+14
-19
lines changed

ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl.cpp

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2222,25 +2222,20 @@ void TPDisk::ProcessChunkWriteQueue() {
22222222
TRequestBase *req = (*it);
22232223
req->SpanStack.PopOk();
22242224
req->SpanStack.Push(TWilson::PDiskDetailed, "PDisk.InBlockDevice", NWilson::EFlags::AUTO_END);
2225-
switch (req->GetType()) {
2226-
case ERequestType::RequestChunkWritePiece:
2227-
{
2228-
TChunkWritePiece *piece = static_cast<TChunkWritePiece*>(req);
2229-
P_LOG(PRI_NOTICE, BPD01, "ChunkWritePiece",
2230-
(ChunkIdx, piece->ChunkWrite->ChunkIdx),
2231-
(Offset, piece->PieceShift),
2232-
(Size, piece->PieceSize)
2233-
);
2234-
bool lastPart = ChunkWritePiece(piece->ChunkWrite.Get(), piece->PieceShift, piece->PieceSize);
2235-
if (lastPart) {
2236-
Mon.IncrementQueueTime(piece->ChunkWrite->PriorityClass, piece->ChunkWrite->LifeDurationMs(now));
2237-
}
2238-
delete piece;
2239-
break;
2240-
}
2241-
default:
2242-
Y_FAIL_S("Unexpected request type# " << ui64(req->GetType()) << " in JointChunkWrites");
2225+
2226+
Y_VERIFY_S(req->GetType() == ERequestType::RequestChunkWritePiece, "Unexpected request type# " << ui64(req->GetType())
2227+
<< " TypeName# " << TypeName(*req) << " in JointChunkWrites");
2228+
TChunkWritePiece *piece = static_cast<TChunkWritePiece*>(req);
2229+
P_LOG(PRI_DEBUG, BPD01, "ChunkWritePiece",
2230+
(ChunkIdx, piece->ChunkWrite->ChunkIdx),
2231+
(Offset, piece->PieceShift),
2232+
(Size, piece->PieceSize)
2233+
);
2234+
bool lastPart = ChunkWritePiece(piece->ChunkWrite.Get(), piece->PieceShift, piece->PieceSize);
2235+
if (lastPart) {
2236+
Mon.IncrementQueueTime(piece->ChunkWrite->PriorityClass, piece->ChunkWrite->LifeDurationMs(now));
22432237
}
2238+
delete piece;
22442239
}
22452240
LWTRACK(PDiskProcessChunkWriteQueue, UpdateCycleOrbit, PCtx->PDiskId, JointChunkWrites.size());
22462241
JointChunkWrites.clear();
@@ -2267,7 +2262,7 @@ void TPDisk::ProcessChunkReadQueue() {
22672262
ui8 priorityClass = read->PriorityClass;
22682263
NHPTimer::STime creationTime = read->CreationTime;
22692264
Y_VERIFY(!read->IsReplied);
2270-
P_LOG(PRI_NOTICE, BPD36, "Performing TChunkReadPiece", (ReqId, reqId), (chunkIdx, chunkIdx),
2265+
P_LOG(PRI_DEBUG, BPD36, "Performing TChunkReadPiece", (ReqId, reqId), (chunkIdx, chunkIdx),
22712266
(PieceCurrentSector, piece->PieceCurrentSector),
22722267
(PieceSizeLimit, piece->PieceSizeLimit),
22732268
(IsTheLastPiece, piece->IsTheLastPiece),

0 commit comments

Comments
 (0)