review fixes: uppercase + forgotten return

Author: jepett0

ydb/core/grpc_services/rpc_describe_external_data_source.cpp

@@ -16,30 +16,30 @@ namespace {
 using TProperties = google::protobuf::Map<TProtoStringType, TProtoStringType>;
 
 void Convert(const TServiceAccountAuth& in, TProperties& out) {
-    out["service_account_id"] = in.GetId();
-    out["service_account_secret_name"] = in.GetSecretName();
+    out["SERVICE_ACCOUNT_ID"] = in.GetId();
+    out["SERVICE_ACCOUNT_SECRET_NAME"] = in.GetSecretName();
 }
 
 void Convert(const TBasic& in, TProperties& out) {
-    out["login"] = in.GetLogin();
-    out["password_secret_name"] = in.GetPasswordSecretName();
+    out["LOGIN"] = in.GetLogin();
+    out["PASSWORD_SECRET_NAME"] = in.GetPasswordSecretName();
 }
 
 void Convert(const TMdbBasic& in, TProperties& out) {
-    out["service_account_id"] = in.GetServiceAccountId();
-    out["service_account_secret_name"] = in.GetServiceAccountSecretName();
-    out["login"] = in.GetLogin();
-    out["password_secret_name"] = in.GetPasswordSecretName();
+    out["SERVICE_ACCOUNT_ID"] = in.GetServiceAccountId();
+    out["SERVICE_ACCOUNT_SECRET_NAME"] = in.GetServiceAccountSecretName();
+    out["LOGIN"] = in.GetLogin();
+    out["PASSWORD_SECRET_NAME"] = in.GetPasswordSecretName();
 }
 
 void Convert(const TAws& in, TProperties& out) {
-    out["aws_access_key_id_secret_name"] = in.GetAwsAccessKeyIdSecretName();
-    out["aws_secret_access_key_secret_name"] = in.GetAwsSecretAccessKeySecretName();
-    out["aws_region"] = in.GetAwsRegion();
+    out["AWS_ACCESS_KEY_ID_SECRET_NAME"] = in.GetAwsAccessKeyIdSecretName();
+    out["AWS_SECRET_ACCESS_KEY_SECRET_NAME"] = in.GetAwsSecretAccessKeySecretName();
+    out["AWS_REGION"] = in.GetAwsRegion();
 }
 
 void Convert(const TToken& in, TProperties& out) {
-    out["token_secret_name"] = in.GetTokenSecretName();
+    out["TOKEN_SECRET_NAME"] = in.GetTokenSecretName();
 }
 
 void Convert(const TAuth& in, TProperties& out) {

ydb/core/grpc_services/rpc_describe_external_table.cpp

@@ -50,6 +50,7 @@ bool ConvertContent(
         issues.AddIssue(TStringBuilder() << "Cannot unpack the content of an external table of type: " << sourceType
             << ", error: " << CurrentExceptionMessage()
         );
+        return false;
     }
     return true;
 }