Skip to content

Commit 7d03938

Browse files
committed
refactor dead session handle logic
1 parent 2d04876 commit 7d03938

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

ydb/aio/query/pool.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,12 @@ async def acquire(self, timeout: float) -> QuerySessionAsync:
5050

5151
try:
5252
_, session = self._queue.get_nowait()
53-
logger.debug(f"Acquired active session from queue: {session._state.session_id}")
54-
return session if session._state.attached else await self._create_new_session()
53+
if session._state.attached:
54+
logger.debug(f"Acquired active session from queue: {session._state.session_id}")
55+
return session
56+
else:
57+
self._current_size -= 1
58+
logger.debug(f"Acquired dead session from queue: {session._state.session_id}")
5559
except asyncio.QueueEmpty:
5660
pass
5761

ydb/query/pool.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,12 @@ def acquire(self, timeout: float) -> QuerySessionSync:
5252

5353
try:
5454
_, session = self._queue.get_nowait()
55-
logger.debug(f"Acquired active session from queue: {session._state.session_id}")
56-
return session if session._state.attached else self._create_new_session()
55+
if session._state.attached:
56+
logger.debug(f"Acquired active session from queue: {session._state.session_id}")
57+
return session
58+
else:
59+
self._current_size -= 1
60+
logger.debug(f"Acquired dead session from queue: {session._state.session_id}")
5761
except queue.Empty:
5862
pass
5963

0 commit comments

Comments
 (0)