Skip to content

Commit 6edda44

Browse files
committed
review fixes
1 parent bf65dc3 commit 6edda44

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

ydb/_topic_reader/datatypes.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -180,22 +180,22 @@ def _pop(self) -> Tuple[List[PublicMessage], bool]:
180180
msgs_left = True if len(self.messages) > 1 else False
181181
return self.messages.pop(0), msgs_left
182182

183-
def _pop_batch(self, size: int) -> PublicBatch:
183+
def _pop_batch(self, message_count: int) -> PublicBatch:
184184
initial_length = len(self.messages)
185185

186-
if size >= initial_length:
186+
if message_count >= initial_length:
187187
raise ValueError("Pop batch with size >= actual size is not supported.")
188188

189189
one_message_size = self._bytes_size // initial_length
190190

191191
new_batch = PublicBatch(
192-
messages=self.messages[:size],
192+
messages=self.messages[:message_count],
193193
_partition_session=self._partition_session,
194-
_bytes_size=one_message_size * size,
194+
_bytes_size=one_message_size * message_count,
195195
_codec=self._codec,
196196
)
197197

198-
self.messages = self.messages[size:]
198+
self.messages = self.messages[message_count:]
199199
self._bytes_size = self._bytes_size - new_batch._bytes_size
200200

201201
return new_batch

ydb/_topic_reader/topic_reader_asyncio.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ def receive_batch_nowait(self, max_messages: Optional[int] = None):
401401
self._buffer_release_bytes(batch._bytes_size)
402402
return batch
403403

404-
cutted_batch = batch._pop_batch(size=max_messages)
404+
cutted_batch = batch._pop_batch(message_count=max_messages)
405405

406406
self._message_batches[part_sess_id] = batch
407407
self._buffer_release_bytes(cutted_batch._bytes_size)

0 commit comments

Comments
 (0)