Skip to content

Commit dcfbf8a

Browse files
author
Илья
committed
Remove cost info
1 parent fd0aece commit dcfbf8a

File tree

3 files changed

+50
-21
lines changed

3 files changed

+50
-21
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
* added cost info and query stats
1+
* added query stats
22

33
## 1.10.0
44
* changed level of update token log record from info to debug

src/Enums/CollectQueryStatsMode.php

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
<?php
2+
namespace YdbPlatform\Ydb\Enums;
3+
use UnexpectedValueException;
4+
use Ydb\Table\QueryStatsCollection\Mode;
5+
6+
class CollectQueryStatsMode
7+
{
8+
9+
const STATS_COLLECTION_UNSPECIFIED = Mode::STATS_COLLECTION_UNSPECIFIED;
10+
11+
const STATS_COLLECTION_NONE = Mode::STATS_COLLECTION_NONE;
12+
13+
const STATS_COLLECTION_BASIC = Mode::STATS_COLLECTION_BASIC;
14+
15+
const STATS_COLLECTION_FULL = Mode::STATS_COLLECTION_FULL;
16+
17+
const STATS_COLLECTION_PROFILE = Mode::STATS_COLLECTION_PROFILE;
18+
19+
private static $valueToName = [
20+
self::STATS_COLLECTION_UNSPECIFIED => 'STATS_COLLECTION_UNSPECIFIED',
21+
self::STATS_COLLECTION_NONE => 'STATS_COLLECTION_NONE',
22+
self::STATS_COLLECTION_BASIC => 'STATS_COLLECTION_BASIC',
23+
self::STATS_COLLECTION_FULL => 'STATS_COLLECTION_FULL',
24+
self::STATS_COLLECTION_PROFILE => 'STATS_COLLECTION_PROFILE',
25+
];
26+
27+
public static function name($value)
28+
{
29+
if (!isset(self::$valueToName[$value])) {
30+
throw new UnexpectedValueException(sprintf(
31+
'Enum %s has no name defined for value %s', __CLASS__, $value));
32+
}
33+
return self::$valueToName[$value];
34+
}
35+
36+
37+
public static function value($name)
38+
{
39+
$const = __CLASS__ . '::' . strtoupper($name);
40+
if (!defined($const)) {
41+
throw new UnexpectedValueException(sprintf(
42+
'Enum %s has no value defined for name %s', __CLASS__, $name));
43+
}
44+
return constant($const);
45+
}
46+
}

src/Traits/RequestTrait.php

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,9 @@
22

33
namespace YdbPlatform\Ydb\Traits;
44

5-
use Ydb\FeatureFlag\Status;
6-
use Ydb\Operations\OperationParams;
75
use Ydb\StatusIds\StatusCode;
86

9-
use Ydb\Table\QueryStatsCollection\Mode;
10-
use Ydb\TableStats\QueryStats;
7+
use YdbPlatform\Ydb\Enums\CollectQueryStatsMode;
118
use YdbPlatform\Ydb\Issue;
129
use YdbPlatform\Ydb\Exception;
1310
use YdbPlatform\Ydb\QueryResult;
@@ -45,9 +42,8 @@ trait RequestTrait
4542
*/
4643
protected $lastDiscovery = 0;
4744

48-
protected $collectStats = Mode::STATS_COLLECTION_UNSPECIFIED;
45+
protected $collectStats = CollectQueryStatsMode::STATS_COLLECTION_UNSPECIFIED;
4946

50-
protected $reportCostInfo = Status::STATUS_UNSPECIFIED;
5147

5248
/**
5349
* Make a request to the service with the given method.
@@ -92,10 +88,6 @@ protected function doRequest($service, $method, array $data = [])
9288
$resultClass = '\\Ydb\\' . $service . '\\' . $method . 'Result';
9389
}
9490

95-
$data['operation_params'] = new OperationParams([
96-
'report_cost_info' => $this->reportCostInfo
97-
]);
98-
9991
$request = new $requestClass($data);
10092

10193
if (method_exists($request, 'setCollectStats')){
@@ -251,7 +243,6 @@ protected function processResponse($service, $method, $response, $resultClass)
251243
}
252244

253245
$this->resetLastRequest();
254-
$result->costInfo = $response->getCostInfo();
255246
return $result;
256247
}
257248
$statusName = StatusCode::name($statusCode);
@@ -393,19 +384,11 @@ protected function checkDiscovery(){
393384
];
394385

395386
/**
396-
* @param int $collectStats \Ydb\Table\QueryStatsCollection\Mode
387+
* @param int $collectStats YdbPlatform\Ydb\Enums\CollectQueryStatsMode
397388
*/
398389
public function setCollectStats(int $collectStats): void
399390
{
400391
$this->collectStats = $collectStats;
401392
}
402393

403-
/**
404-
* @param int $reportCostInfo Ydb.FeatureFlag.Status
405-
*/
406-
public function setReportCostInfo(int $reportCostInfo): void
407-
{
408-
$this->reportCostInfo = $reportCostInfo;
409-
}
410-
411394
}

0 commit comments

Comments
 (0)