Add lambda on exception in retryTransaction

Author: Илья

src/Table.php

@@ -481,21 +481,36 @@ public function retrySession(Closure $userFunc, bool $idempotent = false, RetryP
 
     }
 
-    public function retryTransaction(Closure $userFunc, bool $idempotent = false, RetryParams $params = null){
+    public function retryTransaction(Closure $userFunc, array|bool $idempotentOrParams = false, RetryParams $params = null){
 
-        return $this->retrySession(function (Session $session) use ($userFunc) {
+        if (is_array($idempotentOrParams)){
+            if (isset($idempotentOrParams['idempotent'])){
+                $idempotentFlag = $idempotentOrParams['idempotent'];
+            }
+            if (isset($idempotentOrParams['retry_params'])){
+                $params = $idempotentOrParams['retry_params'];
+            }
+            if (isset($idempotentOrParams['callback_on_error'])){
+                $callbackOnError = $idempotentOrParams['callback_on_error'];
+            }
+        } else {
+            $idempotentFlag = $idempotentOrParams;
+            $callbackOnError = function (\Exception $exception){};
+        }
+        return $this->retrySession(function (Session $session) use ($callbackOnError, $userFunc) {
                 try{
                         $session->beginTransaction();
                         $result = $userFunc($session);
                         $session->commitTransaction();
                         return $result;
-                } catch (Exception $exception){
+                } catch (\Exception $exception){
+                    $callbackOnError($exception);
                     try {
                         $session->rollbackTransaction();
                     } catch (Exception $e){}
                     throw $exception;
                 }
-            }, $idempotent, $params);
+            }, $idempotentFlag, $params);
 
     }
 

tests/RetryOnExceptionTest.php

@@ -4,6 +4,7 @@
 
 use PHPUnit\Framework\TestCase;
 use YdbPlatform\Ydb\Auth\Implement\AnonymousAuthentication;
+use YdbPlatform\Ydb\Exceptions\RetryableException;
 use YdbPlatform\Ydb\Retry\RetryParams;
 use YdbPlatform\Ydb\Session;
 use YdbPlatform\Ydb\Table;
@@ -70,5 +71,15 @@ private function retryTest(Table $table)
                 $tres
             );
         }, true, new RetryParams(2000));
+        $i = 0;
+        $table->retryTransaction(function (Session $session) use (&$i) {
+            if($i == 0){
+                throw new RetryableException('Test exception');
+            }
+            self::assertEquals(5, $i);
+        }, [
+            'idempotent' => true,
+            'callback_on_error' => function (\Exception $exception) use (&$i) {$i=5;}
+        ]);
     }
 }