use oldObj as statefulSet inside IgnoreChangesFunction (#286)

* use oldObj as statefulSet inside IgnoreChangesFunction

* fix typo

Author: kobzonega

.changes/unreleased/Fixed-20250127-141003.yaml

@@ -0,0 +1,3 @@
+kind: Fixed
+body: panic when create object with .spec.pause is true
+time: 2025-01-27T14:10:03.497565+08:00

internal/controllers/database/sync.go

@@ -359,8 +359,8 @@ func (r *Reconciler) waitForStatefulSetToScale(
 
 func shouldIgnoreDatabaseChange(database *resources.DatabaseBuilder) resources.IgnoreChangesFunction {
 	return func(oldObj, newObj runtime.Object) bool {
-		if _, ok := newObj.(*appsv1.StatefulSet); ok {
-			if database.Spec.Pause && *oldObj.(*appsv1.StatefulSet).Spec.Replicas == 0 {
+		if statefulSet, ok := oldObj.(*appsv1.StatefulSet); ok {
+			if database.Spec.Pause && *statefulSet.Spec.Replicas == 0 {
 				return true
 			}
 		}

internal/controllers/storage/sync.go

@@ -292,8 +292,8 @@ func (r *Reconciler) waitForNodeSetsToProvisioned(
 
 func shouldIgnoreStorageChange(storage *resources.StorageClusterBuilder) resources.IgnoreChangesFunction {
 	return func(oldObj, newObj runtime.Object) bool {
-		if _, ok := newObj.(*appsv1.StatefulSet); ok {
-			if storage.Spec.Pause && *oldObj.(*appsv1.StatefulSet).Spec.Replicas == 0 {
+		if statefulSet, ok := oldObj.(*appsv1.StatefulSet); ok {
+			if storage.Spec.Pause && *statefulSet.Spec.Replicas == 0 {
 				return true
 			}
 		}