Skip to content

Commit e31d6b3

Browse files
authored
Merge pull request #485 from alex268/default_async_reader_interface
Added usage of ReadEventHandler as functional interface
2 parents 54ea1d5 + c96dfe7 commit e31d6b3

File tree

2 files changed

+11
-32
lines changed

2 files changed

+11
-32
lines changed

topic/src/main/java/tech/ydb/topic/read/events/AbstractReadEventHandler.java

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -4,31 +4,4 @@
44
* @author Nikolay Perfilov
55
*/
66
public abstract class AbstractReadEventHandler implements ReadEventHandler {
7-
8-
// onMessages(DataReceivedEvent event) method should be defined in user's implementation
9-
10-
@Override
11-
public void onCommitResponse(CommitOffsetAcknowledgementEvent event) {
12-
13-
}
14-
15-
@Override
16-
public void onStartPartitionSession(StartPartitionSessionEvent event) {
17-
event.confirm();
18-
}
19-
20-
@Override
21-
public void onStopPartitionSession(StopPartitionSessionEvent event) {
22-
event.confirm();
23-
}
24-
25-
@Override
26-
public void onPartitionSessionClosed(PartitionSessionClosedEvent event) {
27-
28-
}
29-
30-
@Override
31-
public void onReaderClosed(ReaderClosedEvent event) {
32-
33-
}
347
}

topic/src/main/java/tech/ydb/topic/read/events/ReadEventHandler.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,23 @@
33
/**
44
* @author Nikolay Perfilov
55
*/
6+
@FunctionalInterface
67
public interface ReadEventHandler {
78

89
void onMessages(DataReceivedEvent event);
910

10-
void onCommitResponse(CommitOffsetAcknowledgementEvent event);
11+
default void onCommitResponse(CommitOffsetAcknowledgementEvent event) { }
1112

12-
void onStartPartitionSession(StartPartitionSessionEvent event);
1313

14-
void onStopPartitionSession(StopPartitionSessionEvent event);
14+
default void onStartPartitionSession(StartPartitionSessionEvent event) {
15+
event.confirm();
16+
}
1517

16-
void onPartitionSessionClosed(PartitionSessionClosedEvent event);
18+
default void onStopPartitionSession(StopPartitionSessionEvent event) {
19+
event.confirm();
20+
}
1721

18-
void onReaderClosed(ReaderClosedEvent event);
22+
default void onPartitionSessionClosed(PartitionSessionClosedEvent event) { }
23+
24+
default void onReaderClosed(ReaderClosedEvent event) { }
1925
}

0 commit comments

Comments
 (0)