Skip to content

Commit 4e117f7

Browse files
committed
removed private protobuf dependency from public class WriteAck
1 parent 897c775 commit 4e117f7

File tree

2 files changed

+24
-16
lines changed

2 files changed

+24
-16
lines changed

topic/src/main/java/tech/ydb/topic/write/WriteAck.java

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import java.time.Duration;
44

5-
import tech.ydb.proto.topic.YdbTopic;
6-
75
/**
86
* @author Nikolay Perfilov
97
*/
@@ -50,13 +48,6 @@ public Statistics getStatistics() {
5048
return statistics;
5149
}
5250

53-
private static Duration convert(com.google.protobuf.Duration d) {
54-
if (d == null) {
55-
return Duration.ZERO;
56-
}
57-
return Duration.ofSeconds(d.getSeconds(), d.getNanos());
58-
}
59-
6051
public static class Details {
6152
private final long offset;
6253

@@ -76,12 +67,14 @@ public static class Statistics {
7667
private final Duration maxQueueWaitTime;
7768
private final Duration minQueueWaitTime;
7869

79-
public Statistics(YdbTopic.StreamWriteMessage.WriteResponse.WriteStatistics src) {
80-
this.persistingTime = convert(src.getPersistingTime());
81-
this.partitionQuotaWaitTime = convert(src.getPartitionQuotaWaitTime());
82-
this.topicQuotaWaitTime = convert(src.getTopicQuotaWaitTime());
83-
this.maxQueueWaitTime = convert(src.getMaxQueueWaitTime());
84-
this.minQueueWaitTime = convert(src.getMinQueueWaitTime());
70+
public Statistics(Duration persistingTime,
71+
Duration partitionQuotaWaitTime, Duration topicQuotaWaitTime,
72+
Duration maxQueueWaitTime, Duration minQueueWaitTime) {
73+
this.persistingTime = persistingTime;
74+
this.partitionQuotaWaitTime = partitionQuotaWaitTime;
75+
this.topicQuotaWaitTime = topicQuotaWaitTime;
76+
this.maxQueueWaitTime = maxQueueWaitTime;
77+
this.minQueueWaitTime = minQueueWaitTime;
8578
}
8679

8780
public Duration getPersistingTime() {

topic/src/main/java/tech/ydb/topic/write/impl/WriterImpl.java

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package tech.ydb.topic.write.impl;
22

33
import java.io.IOException;
4+
import java.time.Duration;
45
import java.util.Deque;
56
import java.util.LinkedList;
67
import java.util.List;
@@ -320,6 +321,13 @@ protected void onShutdown(String reason) {
320321
}
321322
}
322323

324+
private static Duration convertDuration(com.google.protobuf.Duration d) {
325+
if (d == null) {
326+
return Duration.ZERO;
327+
}
328+
return Duration.ofSeconds(d.getSeconds(), d.getNanos());
329+
}
330+
323331
private class WriteSessionImpl extends WriteSession {
324332
protected String sessionId;
325333
private final MessageSender messageSender;
@@ -423,7 +431,14 @@ private void onWriteResponse(YdbTopic.StreamWriteMessage.WriteResponse response)
423431
logger.debug("[{}] Received WriteResponse with {} WriteAcks", streamId, acks.size());
424432
WriteAck.Statistics statistics = null;
425433
if (response.getWriteStatistics() != null) {
426-
statistics = new WriteAck.Statistics(response.getWriteStatistics());
434+
YdbTopic.StreamWriteMessage.WriteResponse.WriteStatistics src = response.getWriteStatistics();
435+
statistics = new WriteAck.Statistics(
436+
convertDuration(src.getPersistingTime()),
437+
convertDuration(src.getPartitionQuotaWaitTime()),
438+
convertDuration(src.getTopicQuotaWaitTime()),
439+
convertDuration(src.getMaxQueueWaitTime()),
440+
convertDuration(src.getMinQueueWaitTime())
441+
);
427442
}
428443
int inFlightFreed = 0;
429444
long bytesFreed = 0;

0 commit comments

Comments
 (0)