Skip to content

Commit b85d213

Browse files
committed
fix(TopicData): decode data for message, show error for entire table (#2554)
1 parent 7fca511 commit b85d213

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

src/containers/Tenant/Diagnostics/TopicData/TopicData.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {isNil} from 'lodash';
77
import {DrawerWrapper} from '../../../../components/Drawer';
88
import {EmptyFilter} from '../../../../components/EmptyFilter/EmptyFilter';
99
import EnableFullscreenButton from '../../../../components/EnableFullscreenButton/EnableFullscreenButton';
10+
import {PageError} from '../../../../components/Errors/PageError/PageError';
1011
import Fullscreen from '../../../../components/Fullscreen/Fullscreen';
1112
import {
1213
DEFAULT_TABLE_ROW_HEIGHT,
@@ -293,6 +294,10 @@ export function TopicData({scrollContainerRef, path, database}: TopicDataProps)
293294
);
294295
}, [database, path]);
295296

297+
if (error) {
298+
return <PageError error={error} position="left" />;
299+
}
300+
296301
return (
297302
!isNil(baseOffset) &&
298303
!isNil(baseEndOffset) && (

src/containers/Tenant/Diagnostics/TopicData/TopicDataControls/TopicDataControls.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ export function TopicDataControls({
9797
/>
9898
<TopicDataStartControls scrollToOffset={scrollToOffset} />
9999

100-
{!isNil(startOffset) && !isNil(endOffset) && (
100+
{!isNil(startOffset) && !isNil(endOffset) && endOffset > startOffset && (
101101
<Flex gap={1}>
102102
<Text color="secondary" whiteSpace="nowrap">
103103
{formatNumber(startOffset)}{formatNumber(endOffset - 1)}

src/containers/Tenant/Diagnostics/TopicData/TopicMessageDetails/components/TopicMessage.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ export function TopicMessage({offset, size, message}: TopicMessageProps) {
4141
preparedMessage = decodedMessage;
4242
}
4343
} catch (e) {
44+
preparedMessage = decodedMessage;
4445
console.warn(e);
4546
}
4647

0 commit comments

Comments
 (0)