chore: tests for acl in object overview

Author: Raubzeug

tests/suites/tenant/summary/ObjectSummary.ts

@@ -126,43 +126,34 @@ export class ObjectSummary {
     }
 
     async waitForAclVisible() {
-        await this.aclWrapper.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
+        // In the new UI, the ACL tab shows a redirect message instead of the actual ACL content
+        const redirectMessage = this.page.locator('text=Section was moved to Diagnostics');
+        await redirectMessage.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
         return true;
     }
 
-    async getAccessRights(): Promise<{user: string; rights: string}[]> {
-        await this.waitForAclVisible();
-        const items = await this.aclList.locator('.gc-definition-list__item').all();
-        const result = [];
-
-        for (const item of items) {
-            const user =
-                (await item.locator('.gc-definition-list__term-wrapper span').textContent()) || '';
-            const definitionContent = await item.locator('.gc-definition-list__definition').first();
-            const rights = (await definitionContent.textContent()) || '';
-            result.push({user: user.trim(), rights: rights.trim()});
+    async getRedirectMessage(): Promise<string | null> {
+        const redirectMessage = this.page.locator('text=Section was moved to Diagnostics');
+        if (await redirectMessage.isVisible()) {
+            return redirectMessage.textContent();
         }
-
-        return result;
+        return null;
     }
 
-    async getEffectiveAccessRights(): Promise<{group: string; permissions: string[]}[]> {
-        await this.waitForAclVisible();
-        const items = await this.effectiveAclList.locator('.gc-definition-list__item').all();
-        const result = [];
-
-        for (const item of items) {
-            const group =
-                (await item.locator('.gc-definition-list__term-wrapper span').textContent()) || '';
-            const definitionContent = await item.locator('.gc-definition-list__definition').first();
-            const permissionElements = await definitionContent.locator('span').all();
-            const permissions = await Promise.all(
-                permissionElements.map(async (el) => ((await el.textContent()) || '').trim()),
-            );
-            result.push({group: group.trim(), permissions});
+    async hasOpenInDiagnosticsButton(): Promise<boolean> {
+        try {
+            const diagnosticsButton = this.page.getByRole('button', {name: 'Open in Diagnostics'});
+            await diagnosticsButton.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
+            return true;
+        } catch (error) {
+            console.error('Open in Diagnostics button not visible:', error);
+            return false;
         }
+    }
 
-        return result;
+    async clickOpenInDiagnosticsButton(): Promise<void> {
+        const diagnosticsButton = this.page.getByRole('button', {name: 'Open in Diagnostics'});
+        await diagnosticsButton.click();
     }
 
     async isTreeVisible() {

tests/suites/tenant/summary/objectSummary.test.ts

@@ -158,31 +158,6 @@ test.describe('Object Summary', async () => {
         expect(vslotsColumns).not.toEqual(storagePoolsColumns);
     });
 
-    test('ACL tab shows correct access rights', async ({page}) => {
-        const pageQueryParams = {
-            schema: '/local/.sys_health',
-            database: '/local',
-            summaryTab: 'acl',
-            tenantPage: 'query',
-        };
-        const tenantPage = new TenantPage(page);
-        await tenantPage.goto(pageQueryParams);
-
-        const objectSummary = new ObjectSummary(page);
-        await objectSummary.waitForAclVisible();
-
-        // Check Access Rights
-        const accessRights = await objectSummary.getAccessRights();
-        expect(accessRights).toEqual([{user: 'root@builtin', rights: 'Owner'}]);
-
-        // Check Effective Access Rights
-        const effectiveRights = await objectSummary.getEffectiveAccessRights();
-        expect(effectiveRights).toEqual([
-            {group: 'Access', permissions: ['Manage']},
-            {group: 'Inheritance type', permissions: ['Inherit']},
-        ]);
-    });
-
     test('Copy path copies correct path to clipboard', async ({page}) => {
         const pageQueryParams = {
             schema: dsVslotsSchema,
@@ -294,4 +269,57 @@ test.describe('Object Summary', async () => {
         await objectSummary.expandSummary();
         await expect(objectSummary.isSummaryCollapsed()).resolves.toBe(false);
     });
+
+    test('ACL tab shows redirect message and link to Diagnostics', async ({page}) => {
+        // Define the URL parameters
+        const pageQueryParams = {
+            schema: '/local/.sys_health',
+            database: '/local',
+            summaryTab: 'acl',
+            tenantPage: 'query',
+        };
+
+        // Navigate to the page
+        const tenantPage = new TenantPage(page);
+        await tenantPage.goto(pageQueryParams);
+
+        // Get the ObjectSummary instance
+        const objectSummary = new ObjectSummary(page);
+
+        // Verify the ACL tab is selected
+        await objectSummary.clickTab(ObjectSummaryTab.ACL);
+
+        // Wait for the ACL content to be visible
+        await objectSummary.waitForAclVisible();
+
+        // Check for the redirect message
+        const redirectMessage = await objectSummary.getRedirectMessage();
+        expect(redirectMessage).toContain('Section was moved to Diagnostics');
+
+        // Check for the "Open in Diagnostics" button
+        const hasButton = await objectSummary.hasOpenInDiagnosticsButton();
+        expect(hasButton).toBe(true);
+
+        // Click the button and verify the URL
+        await objectSummary.clickOpenInDiagnosticsButton();
+
+        // Verify the URL contains the expected parameters
+        const expectedUrlParams = new URLSearchParams({
+            tenantPage: 'diagnostics',
+            diagnosticsTab: 'access',
+            summaryTab: 'acl',
+            schema: '/local/.sys_health',
+            database: '/local',
+        });
+
+        // Get the current URL and parse its parameters
+        const currentUrl = page.url();
+        const currentUrlObj = new URL(currentUrl);
+        const currentParams = currentUrlObj.searchParams;
+
+        // Verify each expected parameter is in the URL
+        for (const [key, value] of expectedUrlParams.entries()) {
+            expect(currentParams.get(key)).toBe(value);
+        }
+    });
 });