KESUS: local backups (ydb tools dump / restore) (#14199)

Author: jepett0

include/ydb-cpp-sdk/client/coordination/coordination.h

@@ -4,9 +4,11 @@
 
 namespace Ydb {
 namespace Coordination {
+    class Config;
+    class CreateNodeRequest;
     class DescribeNodeResult;
-    class SemaphoreSession;
     class SemaphoreDescription;
+    class SemaphoreSession;
 }
 }
 
@@ -107,6 +109,8 @@ class TNodeDescription {
     const std::vector<NScheme::TPermissions>& GetEffectivePermissions() const;
     const Ydb::Coordination::DescribeNodeResult& GetProto() const;
 
+    void SerializeTo(Ydb::Coordination::CreateNodeRequest& creationRequest) const;
+
 private:
     struct TImpl;
     std::shared_ptr<TImpl> Impl_;
@@ -189,7 +193,10 @@ struct TNodeSettings : public TOperationRequestSettings<TDerived> {
     FLUENT_SETTING_DEFAULT(ERateLimiterCountersMode, RateLimiterCountersMode, ERateLimiterCountersMode::UNSET);
 };
 
-struct TCreateNodeSettings : public TNodeSettings<TCreateNodeSettings> { };
+struct TCreateNodeSettings : public TNodeSettings<TCreateNodeSettings> {
+    TCreateNodeSettings() = default;
+    TCreateNodeSettings(const Ydb::Coordination::Config& config);
+};
 struct TAlterNodeSettings : public TNodeSettings<TAlterNodeSettings> { };
 struct TDropNodeSettings : public TOperationRequestSettings<TDropNodeSettings> { };
 struct TDescribeNodeSettings : public TOperationRequestSettings<TDescribeNodeSettings> { };

src/api/protos/persqueue_error_codes_v1.proto

@@ -59,4 +59,6 @@ enum ErrorCode {
 
     INVALID_ARGUMENT = 500040;
     VALIDATION_ERROR = 500080;
+
+    UNKNOWN_READ_RULE = 500032;
 }

src/client/coordination/coordination.cpp

@@ -17,7 +17,6 @@ namespace NCoordination {
 using NThreading::TFuture;
 using NThreading::TPromise;
 using NThreading::NewPromise;
-using NYdbGrpc::TQueueClientFixedEvent;
 
 namespace {
 
@@ -35,30 +34,6 @@ inline TResultPromise<T> NewResultPromise() {
 
 ////////////////////////////////////////////////////////////////////////////////
 
-template<class Settings>
-void ConvertSettingsToProtoConfig(
-    const Settings& settings,
-    Ydb::Coordination::Config* config)
-{
-    if (settings.SelfCheckPeriod_) {
-        config->set_self_check_period_millis(settings.SelfCheckPeriod_->MilliSeconds());
-    }
-    if (settings.SessionGracePeriod_) {
-        config->set_session_grace_period_millis(settings.SessionGracePeriod_->MilliSeconds());
-    }
-    if (settings.ReadConsistencyMode_ != EConsistencyMode::UNSET) {
-        config->set_read_consistency_mode(static_cast<Ydb::Coordination::ConsistencyMode>(settings.ReadConsistencyMode_));
-    }
-    if (settings.AttachConsistencyMode_ != EConsistencyMode::UNSET) {
-        config->set_attach_consistency_mode(static_cast<Ydb::Coordination::ConsistencyMode>(settings.AttachConsistencyMode_));
-    }
-    if (settings.RateLimiterCountersMode_ != ERateLimiterCountersMode::UNSET) {
-        config->set_rate_limiter_counters_mode(static_cast<Ydb::Coordination::RateLimiterCountersMode>(settings.RateLimiterCountersMode_));
-    }
-}
-
-////////////////////////////////////////////////////////////////////////////////
-
 std::string GenerateProtectionKey(size_t size) {
     std::string key;
     if (size > 0) {
@@ -89,6 +64,12 @@ struct TNodeDescription::TImpl {
         Proto_ = desc;
     }
 
+    void SerializeTo(Ydb::Coordination::CreateNodeRequest& creationRequest) {
+        auto& config = *creationRequest.mutable_config();
+        config.CopyFrom(Proto_.config());
+        config.clear_path();
+    }
+
     std::optional<TDuration> SelfCheckPeriod_;
     std::optional<TDuration> SessionGracePeriod_;
     EConsistencyMode ReadConsistencyMode_;
@@ -136,6 +117,10 @@ const Ydb::Coordination::DescribeNodeResult& TNodeDescription::GetProto() const
     return Impl_->Proto_;
 }
 
+void TNodeDescription::SerializeTo(Ydb::Coordination::CreateNodeRequest& creationRequest) const {
+    return Impl_->SerializeTo(creationRequest);
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 
 TSemaphoreSession::TSemaphoreSession() {
@@ -1807,6 +1792,52 @@ class TSessionContext : public TThrRefBase {
 
 ////////////////////////////////////////////////////////////////////////////////
 
+namespace {
+
+template<class Settings>
+void ConvertSettingsToProtoConfig(
+    const Settings& settings,
+    Ydb::Coordination::Config* config)
+{
+    if (settings.SelfCheckPeriod_) {
+        config->set_self_check_period_millis(settings.SelfCheckPeriod_->MilliSeconds());
+    }
+    if (settings.SessionGracePeriod_) {
+        config->set_session_grace_period_millis(settings.SessionGracePeriod_->MilliSeconds());
+    }
+    if (settings.ReadConsistencyMode_ != EConsistencyMode::UNSET) {
+        config->set_read_consistency_mode(static_cast<Ydb::Coordination::ConsistencyMode>(settings.ReadConsistencyMode_));
+    }
+    if (settings.AttachConsistencyMode_ != EConsistencyMode::UNSET) {
+        config->set_attach_consistency_mode(static_cast<Ydb::Coordination::ConsistencyMode>(settings.AttachConsistencyMode_));
+    }
+    if (settings.RateLimiterCountersMode_ != ERateLimiterCountersMode::UNSET) {
+        config->set_rate_limiter_counters_mode(static_cast<Ydb::Coordination::RateLimiterCountersMode>(settings.RateLimiterCountersMode_));
+    }
+}
+
+}
+
+TCreateNodeSettings::TCreateNodeSettings(const Ydb::Coordination::Config& config) {
+    if (config.self_check_period_millis() != 0u) {
+        SelfCheckPeriod(TDuration::MilliSeconds(config.self_check_period_millis()));
+    }
+    if (config.session_grace_period_millis() != 0u) {
+        SessionGracePeriod(TDuration::MilliSeconds(config.session_grace_period_millis()));
+    }
+    if (config.read_consistency_mode() != Ydb::Coordination::CONSISTENCY_MODE_UNSET) {
+        ReadConsistencyMode(static_cast<EConsistencyMode>(config.read_consistency_mode()));
+    }
+    if (config.attach_consistency_mode() != Ydb::Coordination::CONSISTENCY_MODE_UNSET) {
+        AttachConsistencyMode(static_cast<EConsistencyMode>(config.attach_consistency_mode()));
+    }
+    if (config.rate_limiter_counters_mode() != Ydb::Coordination::RATE_LIMITER_COUNTERS_MODE_UNSET) {
+        RateLimiterCountersMode(static_cast<ERateLimiterCountersMode>(config.rate_limiter_counters_mode()));
+    }
+}
+
+////////////////////////////////////////////////////////////////////////////////
+
 class TClient::TImpl : public TClientImplCommon<TClient::TImpl> {
 public:
     TImpl(std::shared_ptr<TGRpcConnectionsImpl>&& connections, const TCommonClientSettings& settings)