Skip to content

Commit 99108f7

Browse files
pathsplit -> std::filesystem::path & ui64 -> uint64_t
1 parent 0b71705 commit 99108f7

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

examples/basic_example/basic_example.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
#include <ydb-cpp-sdk/util/string/cast.h>
44

5-
#include <src/util/folder/pathsplit.h>
6-
75
#include <filesystem>
86
#include <format>
97

tests/integration/basic_example_it/basic_example.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
#include "basic_example.h"
22

3-
#include <src/util/folder/pathsplit.h>
43
#include <ydb-cpp-sdk/json_value/ydb_json_value.h>
54

5+
#include <filesystem>
66
#include <format>
77

88
using namespace NYdb;
@@ -19,10 +19,10 @@ static std::string JoinPath(const std::string& basePath, const std::string& path
1919
return path;
2020
}
2121

22-
TPathSplitUnix prefixPathSplit(basePath);
23-
prefixPathSplit.AppendComponent(path);
22+
std::filesystem::path prefixPathSplit(basePath);
23+
prefixPathSplit /= path;
2424

25-
return prefixPathSplit.Reconstruct();
25+
return prefixPathSplit;
2626
}
2727

2828
///////////////////////////////////////////////////////////////////////////////
@@ -176,7 +176,7 @@ static TStatus UpsertSimpleTransaction(TSession session, const std::string& path
176176

177177
//! Shows usage of parameters in data queries.
178178
static TStatus SelectWithParamsTransaction(TSession session, const std::string& path,
179-
ui64 seriesId, ui64 seasonId, std::optional<TResultSet>& resultSet)
179+
uint64_t seriesId, uint64_t seasonId, std::optional<TResultSet>& resultSet)
180180
{
181181
auto query = std::format(R"(
182182
--!syntax_v1
@@ -216,7 +216,7 @@ static TStatus SelectWithParamsTransaction(TSession session, const std::string&
216216

217217
//! Shows usage of prepared queries.
218218
static TStatus PreparedSelectTransaction(TSession session, const std::string& path,
219-
ui64 seriesId, ui64 seasonId, ui64 episodeId, std::optional<TResultSet>& resultSet)
219+
uint64_t seriesId, uint64_t seasonId, uint64_t episodeId, std::optional<TResultSet>& resultSet)
220220
{
221221
// Once prepared, query data is stored in the session and identified by QueryId.
222222
// Local query cache is used to keep track of queries, prepared in current session.
@@ -268,7 +268,7 @@ static TStatus PreparedSelectTransaction(TSession session, const std::string& pa
268268
}
269269

270270
//! Shows usage of transactions consisting of multiple data queries with client logic between them.
271-
static TStatus MultiStepTransaction(TSession session, const std::string& path, ui64 seriesId, ui64 seasonId,
271+
static TStatus MultiStepTransaction(TSession session, const std::string& path, uint64_t seriesId, uint64_t seasonId,
272272
std::optional<TResultSet>& resultSet)
273273
{
274274
auto query1 = std::format(R"(

tests/integration/basic_example_it/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ TEST(Integration, BasicExample) {
6666

6767
std::string expectedResultScanQuerySelect = "{\"series_id\":1,\"season_id\":1,\"title\":\"Season 1\",\"first_aired\":\"2006-02-03\"}\n{\"series_id\":1,\"season_id\":2,\"title\":\"Season 2\",\"first_aired\":\"2007-08-24\"}\n{\"series_id\":1,\"season_id\":3,\"title\":\"Season 3\",\"first_aired\":\"2008-11-21\"}\n{\"series_id\":1,\"season_id\":4,\"title\":\"Season 4\",\"first_aired\":\"2010-06-25\"}\n";
6868
std::vector<std::string> resultScanQuerySelectVector = ScanQuerySelect(client, path);
69-
std::string resultScanQuerySelect = std::reduce(resultScanQuerySelectVector.begin(), resultScanQuerySelectVector.end(), std::string());
69+
std::string resultScanQuerySelect = std::reduce(resultScanQuerySelectVector.begin(), resultScanQuerySelectVector.end());
7070
ASSERT_EQ(resultScanQuerySelect, expectedResultScanQuerySelect);
7171
}
7272
catch (const TYdbErrorException& e) {

0 commit comments

Comments
 (0)