Skip to content

Commit 755c6a8

Browse files
committed
Test with backup & restore rate limiter's properties (#14510)
1 parent 4a3f195 commit 755c6a8

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

include/ydb-cpp-sdk/client/rate_limiter/rate_limiter.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,14 +275,14 @@ struct TDescribeResourceResult : public TStatus {
275275
return HierarchicalDrrProps_;
276276
}
277277

278-
const TMeteringConfig& GetMeteringConfig() const {
278+
const std::optional<TMeteringConfig>& GetMeteringConfig() const {
279279
return MeteringConfig_;
280280
}
281281

282282
private:
283283
std::string ResourcePath_;
284284
THierarchicalDrrProps HierarchicalDrrProps_;
285-
TMeteringConfig MeteringConfig_;
285+
std::optional<TMeteringConfig> MeteringConfig_;
286286
};
287287

288288
using TAsyncDescribeResourceResult = NThreading::TFuture<TDescribeResourceResult>;

src/api/protos/ydb_table.proto

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -543,8 +543,7 @@ message ColumnFamily {
543543
COMPRESSION_ZSTD = 3;
544544
}
545545

546-
// Name of the column family, the name "default" must be used for the
547-
// primary column family that contains at least primary key columns
546+
// Name of the column family
548547
string name = 1;
549548

550549
// This specifies data storage settings for column family
@@ -557,8 +556,9 @@ message ColumnFamily {
557556
// WARNING: DO NOT USE
558557
Ydb.FeatureFlag.Status keep_in_memory = 4;
559558

560-
// Not all compression algorithms support
561-
// Set if want to change default value
559+
// Set the compression level for selected compression type. If no value is specified, default value will be chosen.
560+
// For ZSTD compression level must be in range [-131072:22]
561+
// For other compression types compression level must be empty
562562
optional int32 compression_level = 5;
563563
}
564564

src/client/rate_limiter/rate_limiter.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,9 @@ template struct THierarchicalDrrSettings<TDescribeResourceResult::THierarchicalD
204204
TCreateResourceSettings::TCreateResourceSettings(const Ydb::RateLimiter::CreateResourceRequest& proto)
205205
: THierarchicalDrrSettings(proto.resource().hierarchical_drr())
206206
{
207+
if (proto.resource().has_metering_config()) {
208+
MeteringConfig_ = proto.resource().metering_config();
209+
}
207210
}
208211

209212
TListResourcesResult::TListResourcesResult(TStatus status, std::vector<std::string> paths)

0 commit comments

Comments
 (0)