Skip to content

Commit 6a91cca

Browse files
vitstnGazizonoki
authored andcommitted
Moved commit "Fixed ToBytes/FromBytes for decimal & big tz dates" from ydb repo
1 parent bda8a52 commit 6a91cca

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

src/library/yql_common/decimal/yql_decimal.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ TUint128 GetDivider(ui8 scale) {
1717
}
1818

1919
bool IsError(TInt128 v) {
20-
return v > Nan() || v < -Nan();
20+
return v > Nan() || v < -Inf();
2121
}
2222

2323
bool IsNan(TInt128 v) {
24-
return v == Nan() || v == -Nan();
24+
return v == Nan();
2525
}
2626

2727
bool IsInf(TInt128 v) {
@@ -47,8 +47,6 @@ const char* ToString(TInt128 val, ui8 precision, ui8 scale) {
4747
return "-inf";
4848
if (val == Nan())
4949
return "nan";
50-
if (val == -Nan())
51-
return "-nan";
5250

5351
if (!IsNormal(val)) {
5452
return nullptr;

tests/unit/library/yql_common/decimal/yql_decimal_ut.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -230,19 +230,16 @@ Y_UNIT_TEST_SUITE(TYqlDecimalTest) {
230230
}
231231

232232
Y_UNIT_TEST(TestSpecialAsString) {
233-
UNIT_ASSERT(IsValid("+Nan"));
234-
UNIT_ASSERT(IsValid("-nAn"));
233+
UNIT_ASSERT(IsValid("Nan"));
235234
UNIT_ASSERT(IsValid("INF"));
236235
UNIT_ASSERT(IsValid("-inf"));
237236

238-
UNIT_ASSERT_VALUES_EQUAL(ToString(+Nan(), 10, 2), "nan");
239-
UNIT_ASSERT_VALUES_EQUAL(ToString(-Nan(), 10, 2), "-nan");
237+
UNIT_ASSERT_VALUES_EQUAL(ToString(Nan(), 10, 2), "nan");
240238

241239
UNIT_ASSERT_VALUES_EQUAL(ToString(+Inf(), 10, 2), "inf");
242240
UNIT_ASSERT_VALUES_EQUAL(ToString(-Inf(), 10, 2), "-inf");
243241

244242
UNIT_ASSERT(IsNan(FromString("nan", 10, 2)));
245-
UNIT_ASSERT(IsNan(FromString("-nAN", 12, 7)));
246243
UNIT_ASSERT(IsInf(FromString("+INf", MaxPrecision, 6)));
247244
UNIT_ASSERT(IsInf(FromString("-inF", 4, 2)));
248245
}

0 commit comments

Comments
 (0)