Allow to use per gRPC channel TCP connections (as an option) (#17857)

Author: eivanov89

include/ydb-cpp-sdk/client/driver/driver.h

@@ -50,6 +50,7 @@ class TDriverConfig {
     //! caCerts  - The buffer containing the PEM encoded root certificates for SSL/TLS connections.
     //!            If this parameter is empty, the default roots will be used.
     TDriverConfig& UseSecureConnection(const std::string& caCerts = std::string());
+    TDriverConfig& SetUsePerChannelTcpConnection(bool usePerChannel);
     TDriverConfig& UseClientCertificate(const std::string& clientCert, const std::string& clientPrivateKey);
     //! Set token, this option can be overridden for client by ClientSettings
     TDriverConfig& SetAuthToken(const std::string& token);

src/client/driver/driver.cpp

@@ -34,6 +34,7 @@ class TDriverConfig::TImpl : public IConnectionsParams {
     size_t GetClientThreadsNum() const override { return ClientThreadsNum; }
     size_t GetMaxQueuedResponses() const override { return MaxQueuedResponses; }
     TSslCredentials GetSslCredentials() const override { return SslCredentials; }
+    bool GetUsePerChannelTcpConnection() const override { return UsePerChannelTcpConnection; }
     std::string GetDatabase() const override { return Database; }
     std::shared_ptr<ICredentialsProviderFactory> GetCredentialsProviderFactory() const override { return CredentialsProviderFactory; }
     EDiscoveryMode GetDiscoveryMode() const override { return DiscoveryMode; }
@@ -55,6 +56,7 @@ class TDriverConfig::TImpl : public IConnectionsParams {
     size_t ClientThreadsNum = 0;
     size_t MaxQueuedResponses = 0;
     TSslCredentials SslCredentials;
+    bool UsePerChannelTcpConnection = false;
     std::string Database;
     std::shared_ptr<ICredentialsProviderFactory> CredentialsProviderFactory = CreateInsecureCredentialsProviderFactory();
     EDiscoveryMode DiscoveryMode = EDiscoveryMode::Sync;
@@ -114,6 +116,11 @@ TDriverConfig& TDriverConfig::UseSecureConnection(const std::string& cert) {
     return *this;
 }
 
+TDriverConfig& TDriverConfig::SetUsePerChannelTcpConnection(bool usePerChannel) {
+    Impl_->UsePerChannelTcpConnection = usePerChannel;
+    return *this;
+}
+
 TDriverConfig& TDriverConfig::UseClientCertificate(const std::string& clientCert, const std::string& clientPrivateKey) {
     Impl_->SslCredentials.Cert = clientCert;
     Impl_->SslCredentials.PrivateKey = clientPrivateKey;
@@ -254,7 +261,7 @@ TDriverConfig TDriver::GetConfig() const {
     config.SetMaxOutboundMessageSize(Impl_->MaxOutboundMessageSize_);
     config.SetMaxMessageSize(Impl_->MaxMessageSize_);
     config.Impl_->Log = Impl_->Log;
-    
+
     return config;
 }
 

src/client/impl/ydb_internal/grpc_connections/grpc_connections.cpp

@@ -161,6 +161,7 @@ TGRpcConnectionsImpl::TGRpcConnectionsImpl(std::shared_ptr<IConnectionsParams> p
     , ChannelPool_(TcpKeepAliveSettings_, SocketIdleTimeout_)
 #endif
     , NetworkThreadsNum_(params->GetNetworkThreadsNum())
+    , UsePerChannelTcpConnection_(params->GetUsePerChannelTcpConnection())
     , GRpcClientLow_(NetworkThreadsNum_)
     , Log(params->GetLog())
 {

src/client/impl/ydb_internal/grpc_connections/grpc_connections.h

@@ -117,6 +117,10 @@ class TGRpcConnectionsImpl
             }
         }
 
+        if (UsePerChannelTcpConnection_) {
+            clientConfig.IntChannelParams[GRPC_ARG_USE_LOCAL_SUBCHANNEL_POOL] = 1;
+        }
+
         std::unique_ptr<TServiceConnection<TService>> conn;
 #ifndef YDB_GRPC_BYPASS_CHANNEL_POOL
         ChannelPool_.GetStubsHolderLocked(
@@ -733,6 +737,7 @@ class TGRpcConnectionsImpl
     IDiscoveryMutatorApi::TMutatorCb DiscoveryMutatorCb;
 
     const size_t NetworkThreadsNum_;
+    bool UsePerChannelTcpConnection_;
     // Must be the last member (first called destructor)
     NYdbGrpc::TGRpcClientLow GRpcClientLow_;
     TLog Log;

src/client/impl/ydb_internal/grpc_connections/params.h

@@ -17,6 +17,7 @@ class IConnectionsParams {
     virtual size_t GetClientThreadsNum() const = 0;
     virtual size_t GetMaxQueuedResponses() const = 0;
     virtual TSslCredentials GetSslCredentials() const = 0;
+    virtual bool GetUsePerChannelTcpConnection() const = 0;
     virtual std::string GetDatabase() const = 0;
     virtual std::shared_ptr<ICredentialsProviderFactory> GetCredentialsProviderFactory() const = 0;
     virtual EDiscoveryMode GetDiscoveryMode() const = 0;