gitignore updated | return statement removed from function

Author: yashkathe

.gitignore

@@ -1,2 +1,3 @@
 node_modules
 dist
+junk

.npmignore

@@ -0,0 +1 @@
+src

src/scraper/constructors-standings.ts

@@ -26,7 +26,7 @@ export const getConstructorStandings = (year: number = new Date().getFullYear())
                             const team: string = $(this).find('td:nth-child(3)').text().trim()
                             const points: number = parseInt($(this).find('td:nth-child(4)').text().trim())
 
-                            if (position !== NaN && team.length !== 0 && points !== NaN) {
+                            if (!Number.isNaN(position) && team.length !== 0 && !Number.isNaN(points)) {
                                 const constructorStanding: constructorStanding = {
                                     position,
                                     team,
@@ -36,7 +36,6 @@ export const getConstructorStandings = (year: number = new Date().getFullYear())
                             }
                         })
                     resolve(constructorStandings)
-                    return Promise.all(constructorStandings)
                 })
             .catch(err => { reject(err) })
     })

src/scraper/driver-data.ts

@@ -32,7 +32,7 @@ export const getDriverData = (): Promise<drivers[]> => {
                         const nationalityImage: string | undefined = $(this).find('.container > .row.justify-content-between.align-items-center.listing-item--head > .col-xs-4.country-flag > picture:nth-child(1) > img:nth-child(2)').attr('data-src')
                         const driverImage: string | undefined = $(this).find(' div:nth-child(4) > picture:nth-child(1) > img:nth-child(2)').attr('data-src')
 
-                        if (firstName.length !== 0 && secondName.length !== 0 && team.length !== 0 && rank !== NaN && points !== NaN) {
+                        if (firstName.length !== 0 && secondName.length !== 0 && team.length !== 0 && !Number.isNaN(rank) && !Number.isNaN(points)) {
                             const driver: drivers = {
                                 name: firstName.concat(" ", secondName),
                                 team,
@@ -45,7 +45,6 @@ export const getDriverData = (): Promise<drivers[]> => {
                         }
                     })
                 resolve(drivers)
-                return Promise.all(drivers)
             })
             .catch(err => { reject(err) })
     })

src/scraper/driver-standings.ts

@@ -34,7 +34,7 @@ export const getDriverStandings = (year: number = new Date().getFullYear()): Pro
                             const team: string = $(this).find('td:nth-child(5) > a.grey.semi-bold.uppercase.ArchiveLink').text()
                             const points: number = parseInt($(this).find(' td:nth-child(6) ').text())
 
-                            if (position !== NaN && points !== NaN && driver.length !== 0 && nationality.length !== 0 && team.length !== 0) {
+                            if (!Number.isNaN(position) && !Number.isNaN(points) && driver.length !== 0 && nationality.length !== 0 && team.length !== 0) {
                                 const driverStanding: driverStanding = {
                                     position,
                                     driver,
@@ -46,7 +46,6 @@ export const getDriverStandings = (year: number = new Date().getFullYear()): Pro
                             }
                         })
                     resolve(driverStandings)
-                    return Promise.all(driverStandings)
                 })
             .catch(err => { reject(err) })
     })

src/scraper/team-data.ts

@@ -39,7 +39,7 @@ export const getTeamsData = (): Promise<teams[]> => {
                         const carLogo: string | undefined = $(this).find('div:nth-child(1) > div:nth-child(2) > div:nth-child(2) > picture:nth-child(1) > img:nth-child(2)').attr('data-src')
                         const carImage: string | undefined = $(this).find('div:nth-child(1) > div:nth-child(4) > picture:nth-child(1) > img:nth-child(5)').attr('data-src')
 
-                        if (name.length !== 0 && points !== NaN && rank !== NaN) {
+                        if (name.length !== 0 && !Number.isNaN(points) && !Number.isNaN(rank)) {
                             const team: teams = {
                                 name,
                                 drivers,
@@ -52,7 +52,6 @@ export const getTeamsData = (): Promise<teams[]> => {
                         }
                     })
                 resolve(teams)
-                return Promise.all(teams)
             })
             .catch(err => { reject(err) })
     })