Added 2 more hoisting unit tests

Author: bestander

test/commands/install.js

@@ -280,6 +280,86 @@ test("install should dedupe dependencies avoiding conflicts 5", () => {
   });
 });
 
+test("install should dedupe dependencies avoiding conflicts 6 (jest/jest-runtime case)", () => {
+  // C@1 -> D@1 -> E@1
+  // B@1 -> C@1 -> D@1 -> E@1
+  // D@2
+  // E@2
+
+  // should become
+
+  // C@1 -> D@1
+  //     -> E@1
+  // B@1
+  // D@2
+  // E@2
+
+  return run({}, [], "install-should-dedupe-avoiding-conflicts-6", async (config) => {
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-b/package.json"))).version, "1.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-c/package.json"))).version, "1.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-d/package.json"))).version, "2.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-e/package.json"))).version, "2.0.0");
+
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-c/node_modules/dep-d/package.json"))).version, "1.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-c/node_modules/dep-e/package.json"))).version, "1.0.0");
+  });
+});
+
+test("install should dedupe dependencies avoiding conflicts 7", () => {
+  // A@1 -> C@1 -> D@1 -> E@1
+  // B@1 -> C@1 -> D@1 -> E@1
+  // C@2
+  // D@2
+  // E@2
+
+  // should become
+
+  // A@1 -> C@1
+  //     -> D@1
+  //     -> E@1
+  // B@1 -> C@1
+  //     -> D@1
+  //     -> E@1
+  // C@2
+  // D@2
+  // E@2
+
+  return run({}, [], "install-should-dedupe-avoiding-conflicts-7", async (config) => {
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-a/package.json"))).version, "1.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-b/package.json"))).version, "1.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-c/package.json"))).version, "2.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-d/package.json"))).version, "2.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-e/package.json"))).version, "2.0.0");
+
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-a/node_modules/dep-c/package.json"))).version, "1.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-a/node_modules/dep-d/package.json"))).version, "1.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-a/node_modules/dep-e/package.json"))).version, "1.0.0");
+
+
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-b/node_modules/dep-c/package.json"))).version, "1.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-b/node_modules/dep-d/package.json"))).version, "1.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-b/node_modules/dep-e/package.json"))).version, "1.0.0");
+
+  });
+});
+
 test("upgrade scenario", () => {
   // left-pad first installed 0.0.9 then updated to 1.1.0
   // files in mirror, fbkpm.lock, package.json and node_modules should reflect that

test/fixtures/install/install-should-dedupe-avoiding-conflicts-6/.npmrc

@@ -0,0 +1 @@
+kpm-offline-mirror=./mirror-for-offline

test/fixtures/install/install-should-dedupe-avoiding-conflicts-6/fbkpm.lock

@@ -0,0 +1,30 @@
+dep-b@1.0.0:
+  name dep-b
+  version "1.0.0"
+  resolved dep-b-1.0.0.tgz#3ec41d539ec81cbb0b00f3f77cee143104153783
+  dependencies:
+    dep-c "1.0.0"
+dep-c@1.0.0:
+  name dep-c
+  version "1.0.0"
+  resolved dep-c-1.0.0.tgz#43df1196c1b62b89ed7169b6b93493d8420763b6
+  dependencies:
+    dep-d "1.0.0"
+dep-d@1.0.0:
+  name dep-d
+  version "1.0.0"
+  resolved dep-d-1.0.0.tgz#175ce924c6413b1feeb68b976ae769260cfe0d86
+  dependencies:
+    dep-e "1.0.0"
+dep-d@2.0.0:
+  name dep-d
+  version "2.0.0"
+  resolved dep-d-2.0.0.tgz#ada909b78f52d88a60e9c8583ddc0310ff16da40
+dep-e@1.0.0:
+  name dep-e
+  version "1.0.0"
+  resolved dep-e-1.0.0.tgz#8baa9f7eda12e71a95ccfce7e31ace5867617014
+dep-e@2.0.0:
+  name dep-e
+  version "2.0.0"
+  resolved dep-e-2.0.0.tgz#c326a657226d79e68a2208f62a3f3f9f657416a9

test/fixtures/install/install-should-dedupe-avoiding-conflicts-6/mirror-for-offline/dep-b-1.0.0.tgz

@@ -0,0 +1,8 @@
+{
+  "dependencies": {
+    "dep-b": "1.0.0",
+    "dep-c": "1.0.0",
+    "dep-d": "2.0.0",
+    "dep-e": "2.0.0"
+  }
+}