Skip to content

Commit 1246f74

Browse files
author
Sebastian McKenzie
committed
style nits
1 parent 976fb57 commit 1246f74

File tree

3 files changed

+9
-14
lines changed

3 files changed

+9
-14
lines changed

README.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ $ fbkpm install your-package
8585
### How is this different to existing alternate npm clients such as [ied](https://github.com/alexanderGugel/ied) and [pnpm](https://github.com/rstacruz/pnpm)?
8686

8787
Similar in many aspects but unlike existing alternate npm clients, fbkpm is focused on
88-
security first, excellent performance is just an implementation detail. If we only cared about
89-
performance we'd help improve npm as that doesn't require a change in workflow.
88+
security and determinism first, excellent performance is just an implementation detail. If we only
89+
cared about performance we'd help improve npm as that doesn't require a change in workflow.
9090

9191
### Why not contribute back to npm?
9292

@@ -102,11 +102,7 @@ We hope that some of our ideas make their way back into the main npm client.
102102
### Non-determinism
103103

104104
The npm dependency graph is nondeteriministic and is dependent on install order. This is
105-
terrible for reproducible builds. This is traditionally mitigated by npm with a lock file
106-
and the reshuffling of dependencies inside the graph. This however isn't enough. The use
107-
of a [CAS](https://en.wikipedia.org/wiki/Content-addressable_storage) for storing modules
108-
and sane version resolution against this tree, and using a shrinkwrap by default should
109-
allow for deterministic dependency graphs.
105+
terrible for reproducible builds.
110106

111107
### Option for a flat tree and a single version per package
112108

src/cli/commands/install.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -383,8 +383,7 @@ function shouldWriteLockfile(flags: Object, args: Array<string>): boolean {
383383

384384
export function setFlags(commander: Object) {
385385
commander.usage("install [packages ...] [flags]");
386-
commander.option("-f, --flat", "only allow one version of a package. save all transitive " +
387-
"dependencies as top level.");
386+
commander.option("-f, --flat", "only allow one version of a package");
388387
commander.option("-S, --save", "save package to your `dependencies`");
389388
commander.option("-D, --save-dev", "save package to your `devDependencies`");
390389
commander.option("-P, --save-peer", "save package to your `peerDependencies`");

src/fetchers/tarball.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ import * as crypto from "../util/crypto.js";
1414
import BaseFetcher from "./_base.js";
1515
import * as fsUtil from "../util/fs.js";
1616

17-
let zlib = require("zlib");
18-
let tar = require("tar");
19-
let url = require("url");
2017
let through = require("through2");
21-
let fs = require("fs");
22-
let path = require("path");
18+
let zlib = require("zlib");
19+
let path = require("path");
20+
let tar = require("tar");
21+
let url = require("url");
22+
let fs = require("fs");
2323

2424
export default class TarballFetcher extends BaseFetcher {
2525
async _fetch(dest: string): Promise<string> {

0 commit comments

Comments
 (0)