restrict some kpm commands to only work when there's a lockfile (#143)

Author: Sebastian McKenzie

src/cli/commands/check.js

@@ -13,14 +13,14 @@ import type { Reporter } from "../../reporters/index.js";
 import type Config from "../../config.js";
 import { Install } from "./install.js";
 import Lockfile from "../../lockfile/index.js";
-import { MessageError } from "../../errors.js";
 import * as constants from "../../constants.js";
 import * as fs from "../../util/fs.js";
 import * as util from "../../util/misc.js";
 
 let semver = require("semver");
 let path   = require("path");
 
+export let requireLockfile = true;
 export let noArguments = true;
 
 export function setFlags(commander: Object) {
@@ -33,10 +33,6 @@ export async function run(
   flags: Object,
   args: Array<string>
 ): Promise<void> {
-  if (!await fs.exists(path.join(config.cwd, constants.LOCKFILE_FILENAME))) {
-    throw new MessageError("No lockfile in this directory. Run `fbkpm install` to generate one.");
-  }
-
   let lockfile = await Lockfile.fromDirectory(config.cwd, reporter, {
     silent: true,
     strict: true

src/cli/commands/ls.js

@@ -19,6 +19,7 @@ import Lockfile from "../../lockfile/index.js";
 
 let invariant = require("invariant");
 
+export let requireLockfile = true;
 export let noArguments = true;
 
 function buildCount(trees: ?Trees): number {

src/cli/commands/uninstall.js

@@ -20,6 +20,8 @@ import * as fs from "../../util/fs.js";
 
 let path = require("path");
 
+export let requireLockfile = true;
+
 export async function run(
   config: Config,
   reporter: Reporter,

src/cli/commands/upgrade.js

@@ -13,30 +13,21 @@ import type { Reporter } from "../../reporters/index.js";
 import type Config from "../../config.js";
 import { Install } from "./install.js";
 import Lockfile from "../../lockfile/index.js";
-import { MessageError } from "../../errors.js";
-import * as constants from "../../constants.js";
-import * as fs from "../../util/fs.js";
-
-let path = require("path");
 
 export function setFlags(commander: Object) {
   // TODO: support some flags that install command has
   commander;
 }
 
 export let noArguments = true;
+export let requireLockfile = true;
 
 export async function run(
   config: Config,
   reporter: Reporter,
   flags: Object,
   args: Array<string>
 ): Promise<void> {
-  if (!await fs.exists(path.join(config.cwd, constants.LOCKFILE_FILENAME))) {
-    throw new MessageError("No lockfile in this directory. Run `fbkpm install` to generate one.");
-  }
-
-  // TODO: show and make user approve of updated packages from lockfile. analyse for changes.
   let lockfile = new Lockfile(null, false);
   let install = new Install("update", flags, args, config, reporter, lockfile);
   return install.init();

src/cli/commands/why.js

@@ -16,6 +16,8 @@ import { Install } from "./install.js";
 import Lockfile from "../../lockfile/index.js";
 import * as fs from "../../util/fs.js";
 
+export let requireLockfile = true;
+
 let invariant = require("invariant");
 let emoji     = require("node-emoji");
 let path      = require("path");

src/cli/index.js

@@ -110,6 +110,12 @@ if (network.isOffline()) {
   reporter.warn("You don't appear to have an internet connection.");
 }
 
+//
+if (command.requireLockfile && !fs.existsSync(path.join(config.cwd, constants.LOCKFILE_FILENAME))) {
+  reporter.error("No lockfile in this directory. Run `fbkpm install` to generate one.");
+  process.exit(1);
+}
+
 //
 const run = () => {
   return command.run(config, reporter, commander, commander.args).then(function () {
@@ -118,7 +124,6 @@ const run = () => {
   });
 };
 
-
 //
 const runEventually = () => {
   return new Promise((ok) => {