-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Description
Issue Description
There's a discrepancy in clang-tidy behavior across different versions regarding the passing of boost::uuids::uuid
parameters.
Details
In PR #230, specifically in the TaskExecutor
constructor signature in src/spider/worker/TaskExecutor.hpp
, there's disagreement about whether the parameter should be:
boost::uuids::uuid const task_id
(current implementation)boost::uuids::uuid task_id
(suggested change)
Environment Details
- @sitaowang1998's environment: clang-tidy doesn't complain (both local setup and GitHub workflows)
- @LinZhihao-723's environment: clang-tidy v19.1.0 and CLion's clang-tidy plugin both flag this as an issue
Expected Behavior
clang-tidy should behave consistently across different versions and environments for the same code construct.
References
- PR: feat: Add support for launching language-dependent task executor in workers. #230
- Comment: feat: Add support for launching language-dependent task executor in workers. #230 (comment)
Action Items
- Investigate which clang-tidy versions exhibit this behavior
- Determine the correct/preferred parameter passing style for
boost::uuids::uuid
- Consider standardizing clang-tidy version across development environments
- Update code style guidelines if necessary
Reported by: @LinZhihao-723
Metadata
Metadata
Assignees
Labels
No labels