Skip to content

clang-tidy version discrepancy: boost::uuids::uuid parameter passing style #233

@coderabbitai

Description

@coderabbitai

Issue Description

There's a discrepancy in clang-tidy behavior across different versions regarding the passing of boost::uuids::uuid parameters.

Details

In PR #230, specifically in the TaskExecutor constructor signature in src/spider/worker/TaskExecutor.hpp, there's disagreement about whether the parameter should be:

  • boost::uuids::uuid const task_id (current implementation)
  • boost::uuids::uuid task_id (suggested change)

Environment Details

  • @sitaowang1998's environment: clang-tidy doesn't complain (both local setup and GitHub workflows)
  • @LinZhihao-723's environment: clang-tidy v19.1.0 and CLion's clang-tidy plugin both flag this as an issue

Expected Behavior

clang-tidy should behave consistently across different versions and environments for the same code construct.

References

Action Items

  • Investigate which clang-tidy versions exhibit this behavior
  • Determine the correct/preferred parameter passing style for boost::uuids::uuid
  • Consider standardizing clang-tidy version across development environments
  • Update code style guidelines if necessary

Reported by: @LinZhihao-723

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions