Investigate and fix clang-tidy include-what-you-use violations for system headers

[coderabbitai]

Problem

The CI is failing due to clang-tidy include-what-you-use violations where system headers are being used without being explicitly included. This issue has been observed with multiple system headers, not just <type_traits>.

Current Observations

• PR feat(tdl): Add support for tracking the source location in AST nodes. #199 required adding #include <string_view> to src/spider/tdl/parser/ast/utils.hpp (Line 6)
• Previous issues have been seen with <type_traits> and other system headers

Hypothesis

The root cause might be that when a system header is imported through another system header (transitive inclusion), clang-tidy's include-what-you-use check might not require the former to be explicitly included. However, this behavior may be inconsistent or dependent on specific configurations.

Required Work

1. Investigate the scope: Conduct a comprehensive audit of all files to identify similar violations across the codebase
2. Test the hypothesis: Experiment with different system headers to verify if transitive inclusion affects clang-tidy's requirements
3. Fix violations: Add explicit includes for all system headers that are being used directly
4. Document findings: Update coding guidelines if patterns are discovered

Related

• PR feat(tdl): Add support for tracking the source location in AST nodes. #199: feat(tdl): Add support for tracking the source location in AST nodes. #199
• Comment: feat(tdl): Add support for tracking the source location in AST nodes. #199 (comment)

Assignee

@sitaowang1998

[sitaowang1998]

The .clang-tidy used is from yscope-dev-utils, and it sets misc-include-cleaner as just warning. However, setting misc-include-cleaner as error, both adding or omitting the include line pass clang-tidy check.