generated from y-scope/public-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
Background
In the code-linting-checks workflow, we are locking the task
tool to version v3.44.0 to work around upstream issues in the go-task/task project.
Issues Being Tracked
We need to monitor the resolution of these upstream issues:
- Brace expansion broken in v3.44.1 due to over-escaping of curly braces go-task/task#2401 - Dynamic variable bug (fixed in v3.44.0)
- 0 Exit code even if commands return non-zero exit code go-task/task#2440 - Zero exit code issue where some task versions return success even when tasks fail
Current State
- The code-linting-checks workflow currently pins
@go-task/cli@3.44.0
in npm install commands - Version v3.44.1 has a regression that breaks shell command processing, particularly rsync commands with brace expansion
- This affects the clp-ffi-js project (see clp-ffi-js issue #110)
Action Required
Once both upstream issues are confirmed resolved in a newer task version:
- Test the new version with our workflows
- Verify no regressions in clp-ffi-js project
- Update workflow files to use the newer version or remove version pinning
- Update any related documentation
Files to Update
.github/workflows/code-linting-checks.yaml
References
- Original issue: Unlock task version once upstream issues go-task/task#2401 and go-task/task#2440 are resolved clp#1352
- Upstream issue 1: Brace expansion broken in v3.44.1 due to over-escaping of curly braces go-task/task#2401
- Upstream issue 2: 0 Exit code even if commands return non-zero exit code go-task/task#2440
- Related clp-ffi-js issue: clp-ffi-js#110
- Requested in: ci: Add GitHub workflow to run code linting checks daily, on push, and on pull request. #15 (comment)
/cc @kirkrodrigues
Metadata
Metadata
Assignees
Labels
No labels