Skip to content

Support for Advanced Custom Fields (ACF) version 5 #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kasparsd opened this issue Jul 1, 2020 · 4 comments · Fixed by #1118
Closed

Support for Advanced Custom Fields (ACF) version 5 #1122

kasparsd opened this issue Jul 1, 2020 · 4 comments · Fixed by #1118
Assignees
@kidunot89
Labels
bug integration Integration with other plugins or WordPress core functionality

Comments

@kasparsd
Copy link
Contributor

kasparsd commented Jul 1, 2020

When updating an ACF repeater field (which is inside an ACF Group field),
the Stream plugin crashes as the mysql escape function from WP_DB gets incorrect parameters passed.

https://wordpress.org/support/topic/error-crash-when-updating-acf-repeater-field/
@kasparsd
Copy link
Contributor Author

kasparsd commented Jul 1, 2020

@kidunot89 Would #1118 fix this too?

@kasparsd kasparsd added the bug label Jul 1, 2020
@kidunot89
Copy link
Contributor

kidunot89 commented Jul 1, 2020 •
edited
Loading

@kasparsd No, I wasn't even aware of this issue, but it does coincide with the purpose for the PR so I'll patch it in #1118.

@kidunot89 kidunot89 mentioned this issue Jul 2, 2020
Merged
@kasparsd kasparsd added the integration Integration with other plugins or WordPress core functionality label Jul 7, 2020
@strarsis
Copy link

Has this been fixed now? I want to re-enable stream on that site but I don'T want to trigger these ACF related errors again.

@kidunot89
Copy link
Contributor

kidunot89 commented Sep 11, 2020 •
edited
Loading

@strarsis It should be resolved. Feel free to post here if the issue still persists and I'll reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kidunot89 kidunot89

Labels
bug integration Integration with other plugins or WordPress core functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ACF connector test implemented and ACF v5.x support added kidunot89/stream
3 participants
@kasparsd @strarsis @kidunot89