Post connector updated to account for "new" status

Author: kidunot89

connectors/class-connector-posts.php

@@ -170,7 +170,8 @@ public function callback_transition_post_status( $new, $old, $post ) {
 			return;
 		}
 
-		if ( in_array( $new, array( 'auto-draft', 'inherit' ), true ) ) {
+		$start_statuses = array( 'auto-draft', 'inherit', 'new' );
+		if ( in_array( $new, $start_statuses, true ) ) {
 			return;
 		} elseif ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) {
 			return;
@@ -196,7 +197,7 @@ public function callback_transition_post_status( $new, $old, $post ) {
 				'1: Post title, 2: Post type singular name',
 				'stream'
 			);
-		} elseif ( 'publish' === $new && 'draft' === $old ) {
+		} elseif ( 'publish' === $new && ! in_array( $old, array( 'future', 'publish' ), true ) ) {
 			/* translators: %1$s: a post title, %2$s: a post type singular name (e.g. "Hello World", "Post") */
 			$summary = _x(
 				'"%1$s" %2$s published',
@@ -255,7 +256,7 @@ public function callback_transition_post_status( $new, $old, $post ) {
 			);
 		}
 
-		if ( 'auto-draft' === $old && 'auto-draft' !== $new ) {
+		if ( in_array( $old, $start_statuses, true ) && ! in_array( $new, $start_statuses, true ) ) {
 			$action = 'created';
 		}
 

tests/tests/connectors/test-class-connector-posts.php

@@ -56,7 +56,7 @@ public function test_callback_transition_post_status() {
 		);
 
 		// Set expected calls for the Mock.
-		$this->mock->expects( $this->exactly( 11 ) )
+		$this->mock->expects( $this->exactly( 12 ) )
 			->method( 'log' )
 			->withConsecutive(
 				array(
@@ -80,7 +80,7 @@ function( $subject ) {
 					),
 					$this->greaterThan( 0 ),
 					$this->equalTo( 'post' ),
-					$this->equalTo( 'updated' ),
+					$this->equalTo( 'created' ),
 				),
 				array(
 					$this->equalTo(
@@ -311,7 +311,30 @@ function( $subject ) {
 					$this->greaterThan( 0 ),
 					$this->equalTo( 'post' ),
 					$this->equalTo( 'updated' ),
-				)
+				),
+				array(
+					$this->equalTo(
+						_x(
+							'"%1$s" %2$s published',
+							'1: Post title, 2: Post type singular name',
+							'stream'
+						)
+					),
+					$this->callback(
+						function( $subject ) {
+							$expected = array(
+								'post_title'    => 'Test post',
+								'singular_name' => 'post',
+								'new_status'    => 'publish',
+								'old_status'    => 'new',
+							);
+							return $expected === array_intersect_key( $expected, $subject );
+						}
+					),
+					$this->greaterThan( 0 ),
+					$this->equalTo( 'post' ),
+					$this->equalTo( 'created' ),
+				),
 			);
 
 		// Create post/update post status trigger callbacks.
@@ -383,6 +406,15 @@ function( $subject ) {
 			)
 		);
 
+		// Expected log to be made with "created" action.
+		wp_insert_post(
+			array(
+				'post_title'    => 'Test post',
+				'post_content'  => 'Lorem ipsum dolor...',
+				'post_status'   => 'publish',
+			)
+		);
+
 		/**
 		 * Expected log to not be called for newly published attachment
 		 * because it's an excluded post type.