Skip to content

Commit 736a418

Browse files
committed
update quality plugin
1 parent 4d84168 commit 736a418

39 files changed

+65
-120
lines changed

build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ plugins {
55
id 'signing'
66
id 'ru.vyarus.java-lib' version '3.0.0'
77
id 'ru.vyarus.github-info' version '2.0.0'
8-
id 'ru.vyarus.quality' version '5.0.0'
8+
id 'ru.vyarus.quality' version '6.0.0'
9+
id 'com.github.spotbugs' version '5.2.5' apply false
910
id 'net.researchgate.release' version '3.1.0'
1011
id 'io.github.gradle-nexus.publish-plugin' version '2.0.0'
1112
id 'com.github.ben-manes.versions' version '0.52.0'

src/main/java/ru/vyarus/guice/persist/orient/OrientModule.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,7 @@ protected void loadOptionalPool(final String poolBinder) {
372372
}
373373

374374
@Override
375+
@SuppressWarnings("PMD.UseDiamondOperator")
375376
protected void bindInterceptor(final Matcher<? super Class<?>> classMatcher,
376377
final Matcher<? super Method> methodMatcher,
377378
final MethodInterceptor... interceptors) {

src/main/java/ru/vyarus/guice/persist/orient/RepositoryModule.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ protected void configure() {
105105
/**
106106
* Configures repository annotations interceptor.
107107
*/
108+
@SuppressWarnings("PMD.UseDiamondOperator")
108109
protected void configureAop() {
109110
final RepositoryMethodInterceptor proxy = new RepositoryMethodInterceptor();
110111
requestInjection(proxy);

src/main/java/ru/vyarus/guice/persist/orient/db/DatabaseManager.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,7 @@ public DatabaseManager(
6767
this.dataInitializer = dataInitializer;
6868
this.txTemplate = txTemplate;
6969
// sort pools to correct startup order
70-
Collections.sort(this.pools, new Comparator<PoolManager>() {
71-
@Override
72-
public int compare(final PoolManager o1, final PoolManager o2) {
73-
return o1.getType().compareTo(o2.getType());
74-
}
75-
});
70+
Collections.sort(this.pools, Comparator.comparing(PoolManager::getType));
7671
}
7772

7873
@Override

src/main/java/ru/vyarus/guice/persist/orient/db/pool/DocumentPool.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ public void start(final String database) {
5454
}
5555

5656
@Override
57-
@SuppressWarnings("PMD.NullAssignment")
5857
public void stop() {
5958
if (pool != null) {
6059
pool.close();

src/main/java/ru/vyarus/guice/persist/orient/db/pool/object/OCommandSQLPojoWrapperFixed.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public OCommandSQLPojoWrapperFixed(final OObjectDatabaseTxFixed iDatabase,
3838

3939
@Override
4040
@SuppressWarnings("unchecked")
41-
public <RET> RET execute(final Object... iArgs) {
41+
public <R> R execute(final Object... iArgs) {
4242
database.convertParameters(iArgs);
4343

4444
Object result = command.execute(iArgs);
@@ -85,6 +85,6 @@ public <RET> RET execute(final Object... iArgs) {
8585
result = database.getUserObjectByRecord(((OResult) result).getIdentity().get(), getFetchPlan(), true);
8686
}
8787

88-
return (RET) result;
88+
return (R) result;
8989
}
9090
}

src/main/java/ru/vyarus/guice/persist/orient/db/pool/object/OObjectDatabaseTxFixed.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,18 @@ public OObjectDatabaseTxFixed(final ODatabaseDocumentInternal iDatabase) {
2929
}
3030

3131
@Override
32-
public <RET extends OCommandRequest> RET command(final OCommandRequest iCommand) {
33-
return (RET) new OCommandSQLPojoWrapperFixed(this, underlying.command(iCommand));
32+
public <R extends OCommandRequest> R command(final OCommandRequest iCommand) {
33+
return (R) new OCommandSQLPojoWrapperFixed(this, underlying.command(iCommand));
3434
}
3535

3636
@Override
3737
// changing access, required for fixed wrapper command
38-
@SuppressWarnings("PMD.UselessOverridingMethod")
3938
public void convertParameters(final Object... iArgs) {
4039
super.convertParameters(iArgs);
4140
}
4241

4342
@Override
44-
public <RET> RET load(final ORID iRecordId, final String iFetchPlan, final boolean iIgnoreCache) {
43+
public <R> R load(final ORID iRecordId, final String iFetchPlan, final boolean iIgnoreCache) {
4544
// fixing behaviour after record deletion under ongoing transaction (to unify with legacy behaviour)
4645
try {
4746
return super.load(iRecordId, iFetchPlan, iIgnoreCache);

src/main/java/ru/vyarus/guice/persist/orient/db/scheme/impl/AbstractObjectInitializer.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,7 @@ public void initialize() {
6565
*/
6666
private List<Class<?>> scan() {
6767
final List<Class<?>> modelClasses = Lists.newArrayList();
68-
final Predicate<Class<?>> predicate = new Predicate<Class<?>>() {
69-
@Override
70-
public boolean apply(final Class<?> input) {
71-
return classMatcher.matches(input);
72-
}
73-
};
68+
final Predicate<Class<?>> predicate = classMatcher::matches;
7469
for (String pkg : packages) {
7570
try {
7671
final List<Class<?>> classes = OReflectionHelper

src/main/java/ru/vyarus/guice/persist/orient/db/scheme/initializer/ObjectSchemeInitializer.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
import com.orientechnologies.orient.core.db.object.ODatabaseObject;
66
import com.orientechnologies.orient.object.db.OObjectDatabaseTx;
77
import com.orientechnologies.orient.object.metadata.schema.OSchemaProxyObject;
8-
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
8+
import jakarta.inject.Inject;
9+
import jakarta.inject.Provider;
10+
import jakarta.inject.Singleton;
911
import ru.vyarus.guice.persist.orient.db.scheme.SchemeInitializationException;
1012
import ru.vyarus.guice.persist.orient.db.scheme.initializer.core.ext.ExtensionsDescriptor;
1113
import ru.vyarus.guice.persist.orient.db.scheme.initializer.core.ext.ExtensionsDescriptorFactory;
@@ -14,9 +16,6 @@
1416
import ru.vyarus.guice.persist.orient.db.scheme.initializer.core.spi.type.TypeExtension;
1517
import ru.vyarus.guice.persist.orient.db.scheme.initializer.core.util.SchemeUtils;
1618

17-
import jakarta.inject.Inject;
18-
import jakarta.inject.Provider;
19-
import jakarta.inject.Singleton;
2019
import java.lang.reflect.Field;
2120
import java.util.Map;
2221
import java.util.Set;
@@ -46,7 +45,6 @@
4645
* @since 04.03.2015
4746
*/
4847
@Singleton
49-
@SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
5048
public class ObjectSchemeInitializer {
5149
private final Set<Class<?>> processingCache = Sets.newHashSet();
5250

src/main/java/ru/vyarus/guice/persist/orient/db/scheme/initializer/core/ext/ExtensionsDescriptorFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ private ExtensionsDescriptor.Ext<TypeExtension, Class> createTypeExtension(
6767
final Class<? extends TypeExtension> ext = ann.annotationType()
6868
.getAnnotation(SchemeTypeInit.class).value();
6969
try {
70-
return new ExtensionsDescriptor.Ext<TypeExtension, Class>(injector.getInstance(ext), ann, model);
70+
return new ExtensionsDescriptor.Ext<>(injector.getInstance(ext), ann, model);
7171
} catch (Throwable th) {
7272
throw new SchemeInitializationException(String.format(
7373
"Failed to create extension %s declared by annotation @%s on class %s",
@@ -89,7 +89,7 @@ private ExtensionsDescriptor.Ext<FieldExtension, Field> createFieldExtension(
8989
final Class<? extends FieldExtension> ext = ann.annotationType()
9090
.getAnnotation(SchemeFieldInit.class).value();
9191
try {
92-
return new ExtensionsDescriptor.Ext<FieldExtension, Field>(injector.getInstance(ext), ann, field);
92+
return new ExtensionsDescriptor.Ext<>(injector.getInstance(ext), ann, field);
9393
} catch (Throwable th) {
9494
throw new SchemeInitializationException(String.format(
9595
"Failed to create extension %s declared by annotation @%s on field %s#%s",

0 commit comments

Comments
 (0)