Fix request parameters after calling rewrite() on the request

Author: thekid

ChangeLog.md

@@ -3,6 +3,11 @@ Web change log
 
 ## ?.?.? / ????-??-??
 
+## 4.1.1 / 2024-04-20
+
+* Fixed request parameters being out of sync with the URI after calling
+  the `web.Request::rewrite()` method
+  (@thekid)
 * Made compatible with `xp-forge/uri` version 3.0.0 - @thekid
 
 ## 4.1.0 / 2024-03-24

src/main/php/web/Request.class.php

@@ -56,6 +56,7 @@ public function pass($name, $value) {
    */
   public function rewrite($uri) {
     $this->uri= $this->uri->resolve($uri instanceof URI ? $uri : new URI($uri));
+    $this->params= null; // Force re-evaluation
     return $this;
   }
 

src/test/php/web/unittest/RequestTest.class.php

@@ -51,6 +51,14 @@ public function rewrite_request_relative($uri) {
     Assert::equals(new URI('http://localhost/r'), (new Request(new TestInput('GET', '/')))->rewrite($uri)->uri());
   }
 
+  #[Test, Values([['/', []], ['/?c=test', ['c' => 'test']]])]
+  public function parameters_and_rewriting($uri, $expected) {
+    $req= new Request(new TestInput('GET', '/?a=b&c=d'));
+    $req->params(); // Ensure params are passed from the query string
+
+    Assert::equals($expected, $req->rewrite($uri)->params());
+  }
+
   #[Test]
   public function uri_respects_host_header() {
     Assert::equals(