check_macros 这个要怎么用

[ririyeye]

https://github.com/ririyeye/xmake-debug.git
check_macros("__STDC_FORMAT_MACROS" ,"PRId64" ,{ include = "inttypes.h" , defined = false})
我想检测 如果没有 定义 PRId64 就加上 __STDC_FORMAT_MACROS 这个定义
但是我看这个检查的时候就加上了 __STDC_FORMAT_MACROS 这个定义
/opt/toolchain/arm-himix100-linux/arm/arm-himix100-linux/bin/arm-himix100-linux-gcc -c -D__STDC_FORMAT_MACROS -o /tmp/.xmake1000/250331/_BA01C5A8F055493088C7EFFB7FEA5840.o /tmp/.xmake1000/250331/_862803A46F7945898C84A4CEFBCC9861.c

[waruqi]

定义才会加，取反就只能用 check_cxxsnippets 了

[ririyeye]

check_macros("NEED__STDC_FORMAT_MACROS" ,"PRId64" ,{includes = "inttypes.h" , defined = false, languages = "c++"})
-- check_macros("NEED__STDC_FORMAT_MACROS" ,"PRId64" ,{includes = "inttypes.h" , defined = false})
我发现加了languages选项以后 里面的includes就没作用了 就是上面那条

                #ifndef PRId64
                #else
                #   #error PRId64 is not defined!
                #endif
                
int main(int argc, char** argv)
{

    return 0;
}

检测文件里面就少了include

[waruqi]

languages = "c++"

没这个 language，对标 add_languages 具体取值 看下文档

[ririyeye]

按照这个https://xmake.io/mirror/manual/project_target.html#targetset_languages

我试了下 c++11
check_macros("NEED__STDC_FORMAT_MACROS" ,"PRId64" ,{includes = "inttypes.h" , defined = false, languages = "c++11"})

 /opt/toolchain/arm-himix100-linux/arm/arm-himix100-linux/bin/arm-himix100-linux-gcc -c -DNEED__STDC_FORMAT_MACROS -o /tmp/.xmake1000/250401/_3490FC312BD84E2081EDEF278C27F630.o /tmp/.xmake1000/250401/_E038A6FC9E264D3FB8013F25D1D0827C.c
checking for flags (-fdiagnostics-color=always) ... ok
> arm-himix100-linux-gcc "-fdiagnostics-color=always"
checking for flags (-Wno-gnu-line-marker -Werror) ... ok
> arm-himix100-linux-gcc "-Wno-gnu-line-marker" "-Werror"
> checking for c includes(inttypes.h)
checking for arm-himix100-linux-gcc ... /opt/toolchain/arm-himix100-linux/arm/arm-himix100-linux/bin/arm-himix100-linux-gcc
checking for the c++ compiler (cxx) ... arm-himix100-linux-gcc
checking for flags (-fPIC) ... ok
> arm-himix100-linux-gcc "-fPIC"
> /opt/toolchain/arm-himix100-linux/arm/arm-himix100-linux/bin/arm-himix100-linux-gcc -c -std=c++11 -DNEED__STDC_FORMAT_MACROS -o /tmp/.xmake1000/250401/_CDC8065A60FE49308B47BB49BC461660.o /tmp/.xmake1000/250401/_862803A46F7945898C84A4CEFBCC9861.cpp

                #ifndef PRId64
                #else
                #   #error PRId64 is not defined!
                #endif
                
int main(int argc, char** argv)
{

    return 0;
}

确实检测了c++11 但是没有include

我换了cxx11
check_macros("NEED__STDC_FORMAT_MACROS" ,"PRId64" ,{includes = "inttypes.h" , defined = false, languages = "cxx11"})

> /opt/toolchain/arm-himix100-linux/arm/arm-himix100-linux/bin/arm-himix100-linux-gcc -c -DNEED__STDC_FORMAT_MACROS -o /tmp/.xmake1000/250401/_3FC3E311B93147208E258163D702A030.o /tmp/.xmake1000/250401/_91AB4BEA8358480E9651447B8933A7C9.c
checking for flags (-fdiagnostics-color=always) ... ok
> arm-himix100-linux-gcc "-fdiagnostics-color=always"
checking for flags (-Wno-gnu-line-marker -Werror) ... ok
> arm-himix100-linux-gcc "-Wno-gnu-line-marker" "-Werror"
> checking for c includes(inttypes.h)
> checking for c snippet(NEED__STDC_FORMAT_MACROS)
checkinfo: ...amdir/core/sandbox/modules/import/core/tool/compiler.lua:84: @programdir/modules/core/tools/gcc.lua:980: /tmp/.xmake1000/250401/_91AB4BEA8358480E9651447B8933A7C9.c:7:21: error: invalid preprocessing directive ##
                 #   #error PRId64 is not defined!

#include <inttypes.h>


                #ifndef PRId64
                #else
                #   #error PRId64 is not defined!
                #endif
                
int main(int argc, char** argv)
{

    return 0;
}

检测文件是有include 但是他是c的 不是c++的

[waruqi]

再试试

[ririyeye]

ok
最好还是希望把 这个 add_defines 改到 after_check 里面 这样检测的时候不会干涉 并且和 configvar_check_macros 检测参数一致

--- a/xmake/includes/check/check_macros.lua
+++ b/xmake/includes/check/check_macros.lua
@@ -55,7 +55,6 @@ function check_macros(definition, macros, opt)
         else
             add_csnippets(definition, table.concat(snippets, "\n"))
         end
-        add_defines(definition)
         if opt.languages then
             set_languages(opt.languages)
         end
@@ -76,6 +75,11 @@ function check_macros(definition, macros, opt)
         else
             add_cincludes(opt.includes)
         end
+        after_check(function (option)
+            if option:value() then
+                option:add("defines", definition)
+            end
+        end)
     option_end()
     interp_restore_scope()
     add_options(optname)