xmake install before xpack packaging

[jfulem]

Please, is it possible to somehow call xmake call instead of xmake build. When making the package (NSIS installer) we need to know all dependencies (*.dll) which are copied during the installation.
I tried to use:

 on_buildcmd(function (package, batchcmds)
     batchcmds:run("xmake", {"config", "-m", "release", "--shared=yes", "-y"})
    batchcmds:run("xmake", {"build", "-y"})
    batchcmds:run("xmake", {"install", "-o", "installation"})
    )

add_installfiles("installation/bin/*.*", {prefixdir = "bin"})
add_installfiles("installation/lib/*.*", {prefixdir = "lib"})

But this causes the process to be stucked.

[waruqi]

you need not call them. xpack will install all dll deps in targets if you use add_targets.

https://github.com/xmake-io/xmake/blob/dev/tests/plugins/pack/xmake.lua#L29

[jfulem]

Well, that's the case. When I use add_targets it installs only the deps. It does not install the dlls from the packages.

target("marker")
    -- buildinh executable
    set_kind("binary")
    -- add required packages
    add_packages("zeromq", "cppzmq", "flatbuffers", "nlohmann_json", "protobuf-cpp", "opencv") 

When I call: xmake install it does install also many opencv dlls, libprotobuf and zeromq dll. But when I use the add_targets in xpack I see only the libraries and executables I specified as targets in xmake.lua, there are no libraries from add_packages.

[waruqi]

you can debug

xmake/xmake/plugins/pack/batchcmds.lua

Line 202 in 687bedd

table.join2(libfiles, _get_target_package_libfiles(target))

[jfulem]

@waruqi, it tried to debug it. It looks the problem is on this line:

table.remove_if(libfiles, function (_, libfile) return not depends:has(path.filename(libfile)) end)

here

All relevant files are removed.

[waruqi]

these dlls are unused for target. so xmake will strip them.

xmake/xmake/plugins/pack/batchcmds.lua

Line 101 in fcc2809

if project.policy("install.strip_packagelibs") then

you can use set_policy("install.strip_packagelibs", false) to disable it.

[jfulem]

@waruqi, thanks. When I use your code of batchcmds.lua from fcc2809 everything works fine. I can even use set_policy("install.strip_packagelibs", true)

[jfulem]

Hmm, it looks sometimes it works and sometimes it does not. The same for the xmake install. When I just delete the build directory and rerun the build & install it completely avoids the dependent .dll libraries.

[jfulem]

When I run xmake install and it runs OK, it installs all these libraries:

when I run xmake pack it installs only:
libzmq-v143-mt-4_3_5.dll

When I debug it it looks in this part:

-- we can only reserve used libraries
    if project.policy("install.strip_packagelibs") then
        if target:is_binary() or target:is_shared() or opt.binaryfile then
            local depends = hashset.new()
            _get_target_package_deplibs(opt.binaryfile or target:targetfile(), depends, libfiles, {plat = target:plat(), arch = target:arch()})
            table.remove_if(libfiles, function (_, libfile) return not depends:has(path.filename(libfile)) end)
        end
    end

the libfiles and depends have no common libraries. But I don't understand how this is possible.

[waruqi]

you can debug here

xmake/xmake/plugins/pack/batchcmds.lua

Line 67 in 86627f2

function _get_target_package_deplibs(binaryfile, depends, libfiles, opt)

xmake/xmake/modules/utils/binary/deplibs.lua

Line 26 in 86627f2

function _get_all_depends_by_dumpbin(binaryfile, opt)

[jfulem]

I tried, I spent really some time, but I'm not able to find the issue.

[waruqi]

Please provide a minimal reproducible project.