Building `cxxopts` no longer works on Linux (Ubuntu 24.04)

[slam-bert]

Validation

• I've read the FAQ.
• The Xenia build used is from the master branch (not MLBS/AlexVS/Canary/pull requests, etc.)
• This issue isn't for tech support (help with Xenia).
• If this issue occurs in a specific game, I've done analysis to locate the faulty subsystem of the emulator and a potential reason in it.
• I've checked if this issue hasn't already been reported.
• My device meets the minimum requirements: https://github.com/xenia-project/xenia/wiki/Quickstart#system-requirements
• (If building) I have read the building doc: https://github.com/xenia-project/xenia/blob/master/docs/building.md

Describe what's going wrong

When compiling the latest commit of Xenia on Linux as of this post (3d30b2e), building cxxopts fails with multiple of the same error.

I was able to resolve the errors by replacing
if (u > static_cast<U>(-(std::numeric_limits<T>::min)()))
with
if (u > static_cast<U>((std::numeric_limits<T>::min)()))
in cxxopts.hpp.
I got this fix from the latest cxxopts commit as of posting (2ad116a).

If possible, could this fix be somehow implemented?

Describe what should happen

cxxopts should compile just fine.

If applicable, provide a callstack here, especially for crashes

No response

If applicable, upload a logfile and link it here

Building debug...

- running premake...
Building configurations...
    Baking aes_128...
    Baking capstone...
    Baking dxbc...
    Baking discord-rpc...
    Baking cxxopts...
    Baking cpptoml...
    Baking libavcodec...
    Baking libavutil...
    Baking fmt...
    Baking glslang-spirv...
    Baking imgui...
    Baking mspack...
    Baking snappy...
    Baking xxhash...
    Baking xenia-core...
    Baking xenia-app...
    Baking xenia-app-discord...
    Baking xenia-apu...
    Baking xenia-apu-nop...
    Baking xenia-base...
    Baking xenia-base-tests...
    Baking xenia-cpu...
    Baking xenia-cpu-tests...
    Baking xenia-cpu-ppc-tests...
    Baking xenia-cpu-backend-x64...
    Baking xenia-debug-ui...
    Baking xenia-gpu...
    Baking xenia-gpu-shader-compiler...
    Baking xenia-gpu-null...
    Baking xenia-gpu-vulkan...
    Baking xenia-gpu-vulkan-trace-viewer...
    Baking xenia-gpu-vulkan-trace-dump...
    Baking xenia-hid...
    Baking xenia-hid-demo...
    Baking xenia-hid-nop...
    Baking xenia-kernel...
    Baking xenia-ui...
    Baking xenia-ui-vulkan...
    Baking xenia-ui-window-vulkan-demo...
    Baking xenia-vfs...
    Baking xenia-vfs-dump...
    Baking xenia-vfs-tests...
    Baking xenia-apu-sdl...
    Baking xenia-helper-sdl...
    Baking xenia-hid-sdl...
Running action 'gmake2'...
Done (1204ms).

- building (all):debug...
make: Entering directory '/home/brt/Downloads/xenia/build'
==== Building aes_128 (debug_linux) ====
==== Building capstone (debug_linux) ====
==== Building dxbc (debug_linux) ====
==== Building discord-rpc (debug_linux) ====
==== Building cxxopts (debug_linux) ====
==== Building cpptoml (debug_linux) ====
==== Building libavutil (debug_linux) ====
==== Building fmt (debug_linux) ====
==== Building glslang-spirv (debug_linux) ====
==== Building imgui (debug_linux) ====
==== Building xenia-base (debug_linux) ====
==== Building snappy (debug_linux) ====
==== Building xxhash (debug_linux) ====
==== Building xenia-app-discord (debug_linux) ====
==== Building xenia-helper-sdl (debug_linux) ====
clock.cc
clock_posix.cc
clock_x64.cc
cvar.cc
In file included from ../src/xenia/base/clock_x64.cc:10:
In file included from ../src/xenia/base/clock.h:16:
In file included from ../src/xenia/base/cvar.h:19:
../third_party/cxxopts/include/cxxopts.hpp:488:36: error: overflow in expression; result is -2147483648 with type 'int' [-Werror,-Winteger-overflow]
In file included from ../src/xenia/base/clock_posix.cc:13:
  In file included from 488../src/xenia/base/clock.h | : 16 :
 In file included from  ../src/xenia/base/cvar.h : 19 :
  ../third_party/cxxopts/include/cxxopts.hpp : 488 if (u: 36>:  staerror: ticoverflow in expression; result is -2147483648 with type 'int' [-Werror,-Winteger-overflow]_c
ast<U>(-(std::n  u488m | e r i c _ l i m i t s < Ti>f: :(mui n>) (s)t)a)ti
c      _| ca                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~s
t<U>(-(std::numeric_limits<T>::min)()))
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../third_party/cxxopts/include/cxxopts.hpp:488:36: error: overflow in expression; result is -9223372036854775808 with type 'long' [-Werror,-Winteger-overflow]
  488 |             if (u > static_cast<U>(-(std::numeric_limits<T>::min)()))
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../third_party/cxxopts/include/cxxopts.hpp:488:36: error: overflow in expression; result is -9223372036854775808 with type 'long' [-Werror,-Winteger-overflow]
  488 |             if (u > static_cast<U>(-(std::numeric_limits<T>::min)()))
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/xenia/base/clock.cc:10:
In file included from ../src/xenia/base/clock.h:16:
In file included from ../src/xenia/base/cvar.h:19:
../third_party/cxxopts/include/cxxopts.hpp:488:36: error: overflow in expression; result is -2147483648 with type 'int' [-Werror,-Winteger-overflow]
  488 |             if (u > static_cast<U>(-(std::numeric_limits<T>::min)()))
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../third_party/cxxopts/include/cxxopts.hpp:488:36: error: overflow in expression; result is -9223372036854775808 with type 'long' [-Werror,-Winteger-overflow]
  488 |             if (u > static_cast<U>(-(std::numeric_limits<T>::min)()))
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/xenia/base/cvar.cc:10:
In file included from ../src/xenia/base/cvar.h:19:
../third_party/cxxopts/include/cxxopts.hpp:488:36: error: overflow in expression; result is -2147483648 with type 'int' [-Werror,-Winteger-overflow]
  488 |             if (u > static_cast<U>(-(std::numeric_limits<T>::min)()))
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../third_party/cxxopts/include/cxxopts.hpp:488:36: error: overflow in expression; result is -9223372036854775808 with type 'long' [-Werror,-Winteger-overflow]
  488 |             if (u > static_cast<U>(-(std::numeric_limits<T>::min)()))
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
2 errors generated.
make[1]: *** [xenia-base.make:249: obj/Linux/Debug/Linux/Debug/xenia-base/clock_posix.o] Error 1
make[1]: *** Waiting for unfinished jobs....
==== Building libavcodec (debug_linux) ====
make[1]: *** [xenia-base.make:252: obj/Linux/Debug/Linux/Debug/xenia-base/clock_x64.o] Error 1
2 errors generated.
make[1]: *** [xenia-base.make:246: obj/Linux/Debug/Linux/Debug/xenia-base/clock.o] Error 1
2 errors generated.
make[1]: *** [xenia-base.make:258: obj/Linux/Debug/Linux/Debug/xenia-base/cvar.o] Error 1
make: *** [Makefile:287: xenia-base] Error 2
make: Leaving directory '/home/brt/Downloads/xenia/build'

ERROR: build failed with one or more errors.

[Shoegzer]

It's failing to build here too, on Linux Mint 22, which uses the Ubuntu 24.04 base. However, it fails earlier than cxxopts, with errors such as the following:

../../contrib/libzip/mkstemp.c: In function ‘_zip_mkstemp’:
../../contrib/libzip/mkstemp.c:76:15: error: implicit declaration of function ‘getpid’ [-Wimplicit-function-declaration]
   76 |         pid = getpid();
      |               ^~~~~~
lbitlib.c
make[2]: *** [zip-lib.make:303: obj/Release/zip-lib/mkstemp.o] Error 1
make[1]: *** [Makefile:74: zip-lib] Error 2
make[1]: *** Waiting for unfinished jobs....

This is related to gcc-14 pickiness, as explained here. I'm guessing you're using gcc-13 or below.

Here's my full build.log: xenia_build_log.txt

[nullequal]

It's failing to build here too, on Linux Mint 22, which uses the Ubuntu 24.04 base. However, it fails earlier than cxxopts, with errors such as the following:

../../contrib/libzip/mkstemp.c: In function ‘_zip_mkstemp’:
../../contrib/libzip/mkstemp.c:76:15: error: implicit declaration of function ‘getpid’ [-Wimplicit-function-declaration]
   76 |         pid = getpid();
      |               ^~~~~~
lbitlib.c
make[2]: *** [zip-lib.make:303: obj/Release/zip-lib/mkstemp.o] Error 1
make[1]: *** [Makefile:74: zip-lib] Error 2
make[1]: *** Waiting for unfinished jobs....

This is related to gcc-14 pickiness, as explained here. I'm guessing you're using gcc-13 or below.

Here's my full build.log: xenia_build_log.txt

easily fixable by adding #include <unistd.h> in mkstemp.c

[nullequal]

more implicit declarations with the zip_ files
fixable by adding #include <unistd.h> to all of them

[Shoegzer]

Nice find. Can you make a PR with the additions?

[nullequal]

your issue is also fixable by updating the premake-core fork to the latest master
i believe fixing it this way is better. (i cant PR this however due to insufficient permissions)
please do test it yourself and notify me

[Shoegzer]

Thanks. Attempted a git clone --recursive to update submodules including premake-core, but building still fails with the same results as above.

[nullequal]

can you try building premake-core from premake instead of using the xenia fork?
(clone the repo and run make -f Bootstrap.mak)

[Shoegzer]

Thanks. After cloning the xenia repo, I substituted the xenia fork of premake-core with the upstream source in .gitmodules and then ran xb setup (which I believe executes make -f Boostrap.mak), however it still fails with the same results as above.

[nullequal]

you missed a step. you have to pull premake-core master and then commit
also, changing a submodule's URL in a local repo has some more steps other than just changing .gitmodules but I think git submodule set-url can do it.

(if you want to save yourself the hassle, you can use my fork's branch update-premake which i used to test this)

[Shoegzer]

Ah yes, thanks for pointing that out. And actually, I just cloned your fork and did a git checkout update-premake but the xb setup threw the following error, do you know why? I assume it's looking for the original premake url.

Submodule path 'third_party/premake-cmake': checked out '91c646f638a6fbff20f0ea90769df8dcf62bc5e4'
fatal: remote error: upload-pack: not our ref 89971527dfe76690f52b74253478c1f037fe2c4b
fatal: Fetched in submodule path 'third_party/premake-core', but it did not contain 89971527dfe76690f52b74253478c1f037fe2c4b. Direct fetching of that commit failed.
Traceback (most recent call last):
  File "/home/testing/Desktop/xenia/./xb", line 1842, in <module>
    main()
  File "/home/testing/Desktop/xenia/./xb", line 179, in main
    return_code = command.execute(args, pass_args, os.getcwd())
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/testing/Desktop/xenia/./xb", line 674, in execute
    git_submodule_update()
  File "/home/testing/Desktop/xenia/./xb", line 418, in git_submodule_update
    shell_call([
  File "/home/testing/Desktop/xenia/./xb", line 252, in shell_call
    subprocess.check_call(command, shell=shell, stdout=stdout_file, stderr=stderr_file)
  File "/usr/lib/python3.12/subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', '-c', 'fetch.recurseSubmodules=on-demand', 'submodule', 'update', '--init']' returned non-zero exit status 128.

[nullequal]

you can replace line 674 from xenia-build to preserve the commit (i messed up pulling the master so i recommend just not allowing the script to run git submodule update)

i will fix the fork soon enough do not worry

[Shoegzer]

Thanks. Commenting out 674 wouldn't work because it's nested in an if/else, so I commented the statement (673-676). However since premake isn't built, it can't execute. What did you have in mind here if it wasn't this?

[nullequal]

maybe only replace line 674 with a statement like print('')