Skip to content

Commit 9b33a0d

Browse files
author
Xavier Jefferson
committed
Fix bug with sql job parameter statement
1 parent 597d999 commit 9b33a0d

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

Hangfire.FluentNHibernateStorage/FluentNHibernateJobStorageConnection.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,8 @@ public override void SetJobParameter(string id, string name, string value)
105105
Storage.UseTransaction(session =>
106106
{
107107
var rowCount = session.CreateQuery(SqlUtil.SetJobParameterStatement)
108-
.SetParameter("value", value).SetParameter("id", converter.Value).ExecuteUpdate();
108+
.SetParameter("value", value).SetParameter("id", converter.Value).SetParameter("name", name)
109+
.ExecuteUpdate();
109110
if (rowCount == 0)
110111
{
111112
session.Insert(

Hangfire.FluentNHibernateStorage/SqlUtil.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,8 @@ internal static class SqlUtil
127127
private static string _createDistributedLockStatement;
128128

129129
internal static readonly string SetJobParameterStatement = string.Format(
130-
"update {0} set {1}=:value where {2}.{3}=:id",
131-
nameof(_JobParameter), nameof(_JobParameter.Value), nameof(_JobParameter.Job), nameof(_Job.Id));
130+
"update {0} set {1}=:value where {2}.{3}=:id and {4}=:name",
131+
nameof(_JobParameter), nameof(_JobParameter.Value), nameof(_JobParameter.Job), nameof(_Job.Id), nameof(_JobParameter.Name));
132132

133133
internal static readonly string AnnounceServerStatement = string.Format(
134134
"update {0} set {1}=:data, {2}=:lastheartbeat where {3}=:id", nameof(_Server), nameof(_Server.Data),

nuspecs/Hangfire.FluentNHibernateStorage.nuspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<package>
44
<metadata>
55
<id>Hangfire.FluentNHibernateStorage</id>
6-
<version>1.1.2400</version>
6+
<version>1.1.2405</version>
77
<authors>Xavier Jefferson</authors>
88
<owners>XavierJefferson</owners>
99
<licenseUrl>https://www.gnu.org/licenses/lgpl-3.0.en.html</licenseUrl>
@@ -12,7 +12,7 @@
1212
<requireLicenseAcceptance>false</requireLicenseAcceptance>
1313
<description>A Hangfire storage provider for SQL Server, MySQL, Oracle, DB/2, PostgreSQL, and Firebird</description>
1414
<releaseNotes>
15-
Incorporate monitoring changes from Mateusz Bogusz
15+
Incorporating changes for job parameters from Alex Fas
1616
</releaseNotes>
1717
<copyright>Copyright © 2019 Xavier Jefferson</copyright>
1818
<tags>hangfire storage provider mssql mysql oracle postgresql firebird db2</tags>

0 commit comments

Comments
 (0)