Skip to content

Commit fad545a

Browse files
committed
minor symfony#19163 [Console] removed unneeded private methods (fabpot)
This PR was merged into the 2.7 branch. Discussion ---------- [Console] removed unneeded private methods | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | https://github.com/symfony/symfony/pull/19134/files/3871e1a95056ce8278e6b86d3e8005836ecab954#r68286709 | License | MIT | Doc PR | n/a Commits ------- 35f32eb [Console] removed unneeded private methods
2 parents 448a390 + 35f32eb commit fad545a

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

src/Symfony/Component/Console/Helper/ProgressBar.php

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ private function setMaxSteps($max)
523523
private function overwrite($message)
524524
{
525525
if ($this->overwrite) {
526-
if (!$this->isFirstRun()) {
526+
if (!$this->firstRun) {
527527
// Move the cursor to the beginning of the line
528528
$this->output->write("\x0D");
529529

@@ -539,7 +539,7 @@ private function overwrite($message)
539539
$this->output->writeln('');
540540
}
541541

542-
$this->setFirstRun(false);
542+
$this->firstRun = false;
543543

544544
$this->output->write($message);
545545
}
@@ -632,14 +632,4 @@ private static function initFormats()
632632
'debug_nomax' => ' %current% [%bar%] %elapsed:6s% %memory:6s%',
633633
);
634634
}
635-
636-
private function isFirstRun()
637-
{
638-
return $this->firstRun;
639-
}
640-
641-
private function setFirstRun($firstRun)
642-
{
643-
$this->firstRun = (bool) $firstRun;
644-
}
645635
}

0 commit comments

Comments
 (0)