Skip to content

Commit dcd4d2e

Browse files
committed
minor symfony#17913 [2.8] [Form] minor fix some regression in tests with placeholder in AbstractLayout (HeahDude)
This PR was merged into the 2.8 branch. Discussion ---------- [2.8] [Form] minor fix some regression in tests with placeholder in AbstractLayout | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | - Commits ------- 6977583 [2.8] [Form] minor fix some tests with placeholder in AbstractLayout
2 parents 20d4c58 + 6977583 commit dcd4d2e

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/Symfony/Component/Form/Tests/AbstractBootstrap3LayoutTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -847,7 +847,8 @@ public function testSingleChoiceExpandedWithPlaceholderWithoutTranslation()
847847
'choices_as_values' => true,
848848
'multiple' => false,
849849
'expanded' => true,
850-
'translation_domain' => false,
850+
'required' => false,
851+
'choice_translation_domain' => false,
851852
'placeholder' => 'Placeholder&Not&Translated',
852853
));
853854

src/Symfony/Component/Form/Tests/AbstractLayoutTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1016,6 +1016,7 @@ public function testSingleChoiceExpandedWithoutTranslation()
10161016
'multiple' => false,
10171017
'expanded' => true,
10181018
'choice_translation_domain' => false,
1019+
'placeholder' => 'Placeholder&Not&Translated',
10191020
));
10201021

10211022
$this->assertWidgetMatchesXpath($form->createView(), array(),
@@ -1092,7 +1093,8 @@ public function testSingleChoiceExpandedWithPlaceholderWithoutTranslation()
10921093
'choices_as_values' => true,
10931094
'multiple' => false,
10941095
'expanded' => true,
1095-
'translation_domain' => false,
1096+
'required' => false,
1097+
'choice_translation_domain' => false,
10961098
'placeholder' => 'Placeholder&Not&Translated',
10971099
));
10981100

0 commit comments

Comments
 (0)