Consider checking that there is only 1 primary (green) button

[frankieroberto]

The Design System guidance for Buttons says:

Use a default button for the main call to action on a page.

Avoid using multiple default buttons on a single page. Having more than one main call to action reduces their impact, and makes it harder for users to know what to do next.

We could consider checking for this. However the guidance is only "avoid" rather than a hard rule, so it might need to be overridden.

[frankieroberto]

Reposting this here from @joelanman:

Is having 2 green primary buttons on a page wrong?

Mostly, yes - I would include the multiple green error:

Avoid using multiple default buttons on a single page. Having more than one main call to action reduces their impact, and makes it harder for users to know what to do next.

The option to manually ignore with a flag sounds good, that means you know about the issue and made a conscious decision

Originally posted by @joelanman in #8 (comment)

[frankieroberto]

Reposting this here from @frankieroberto:

Potentially we could output warning messages to the console log, unless you deliberately silence them. But they might still get ignored.

Another option would be to make the test fail unless you explicitly override it somehow. I did that for the disabled links, where you have to pass disabled: true. Could do something similar:

click_govuk_button("Continue",  ignore_other_primary_buttons: true)

...or some kind of global setting somewhere. Feels a bit icky though, somehow?

Another alternative would be just to make the helper more opinionated and always fail if there are 2 primary buttons. Teams could still fall back to using click_button if they really wanted to ignore the warning...