Replies: 1 comment
-
(Sam did ask about this change before we implanted it and you agreed in principle: it's the change from |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
The initial design has core read environment information from the gitlab repo using a remote call.
There was a discussion that concluded that core should be the only thing writing to the repo, to avoid any conflict possibilities.
That being the case, I think it makes sense to keep the change Sam and I made recently that has core read environment info from the local clone, not direct from the remote. This not only helps with testing, but also gives us a probably-good-enough caching system for free (the OS will likely cache all the disk reads we do), rather than have to make a remote call to gitlab on every front-end search request.
Beta Was this translation helpful? Give feedback.
All reactions