About the IEnumerator object is never disposed warning

[stenci]

I am exploring the library and noticed the warning IEnumerator object is never disposed; consider safe-cast to IDisposable and Dispose() call after enumeration:

This would be a solution:

    public override IEnumerator<T> GetEnumerator()
    {
      var enumerator = ids.GetEnumerator();
      try
      {
        while (enumerator.MoveNext())
        {
          yield return getID(enumerator.Current);
        }
      }
      finally
      {
        if (enumerator is IDisposable disposable)
        {
          disposable.Dispose();
        }
      }
    }

I would like to know if the warning was intentionally ignored, and if yes, why.

---

Reading your blog posts I learned something about working with AutoCAD APIs. I wish the official documentation had this and this tables!

Exploring your library I am learning about clean C# and project organization.

Thank you!

[benkoshy]

I would like to know if the warning was intentionally ignored, and if yes, why.

Isn't it automatically disposed in the finally block?

[stenci]

There is no finally block.

[wtertinek]

Hi, stenci,

I'm very glad my posts and the Code have been helpful. Feel free to reach out if you have any further questions.

I do not get the warning in my IDE (I'm using VS 2022).

Calling Dispose() is ignored here on purpuse, because the underlying object is an AutoCAD container object (eg. BlockTable) and it would have a negative effect if we dispose of the object here and then use it further down the call chain. Furthermore, there are only two AutoCAD classes I'm aware of whose objects have to be disposed of explicitly, ObjectIdCollection and IdMapping.

[stenci]

I do not get the warning in my IDE (I'm using VS 2022).

I use JetBrains Rider 2022 and I have targeted .net 4.8 instead of 4.5. I guess one of the two caused the warning to appear.