-
Notifications
You must be signed in to change notification settings - Fork 137
have_enqueued_sidekiq_job without argument default behavior
The choice has been made to treat have_enqueued_sidekiq_job
without arguments as more permissive so that we're more inline with the general patterns of other builtins (e.g., raise_error
) and other similar libraries (like rspec-rails
). The default will be to use any_args
if you do not provide expected arguments.
# Versions >= 5.x
have_enqueued_sidekiq_job == have_enqueued_sidekiq_job(any_args)
If you were relying on the previous behavior, you'll want to provide no_args
to the matcher. Doing so will drop the warning for the given usage.
# if you need to maintain legacy behavior
expect(AwesomeJob).to have_enqueued_sidekiq_job(no_args)
After reviewing you tests to ensure you're comfortable with the upcoming new behavior, you can silence any remaining warnings entirely with:
RSpec::Sidekiq.configure do |config|
config.silence_warning(:have_enqueued_sidekiq_job_default)
end
In the first few major versions of this gem, the behavior of using have_enqueued_sidekiq_job
without any arguments was equivalent to explicitly expecting no arguments were expected when enqueuing the given Sidekiq job.
# Versions <= 4.x
have_enqueued_sidekiq_job == have_enqueued_sidekiq_job(no_args)
In an effort to be more inline with the general patterns of other builtins (e.g., raise_error
) and other similar libraries (like rspec-rails
), the default going forward will be to use any_args
.
# Versions >= 5.x
have_enqueued_sidekiq_job == have_enqueued_sidekiq_job(any_args)