Merge pull request #100 from jrfnl/feature/cs-fixes-3

PHPCS: fix up the code base [3] - strict comparisons

Author: schlessera

src/Search_Replace_Command.php

@@ -302,7 +302,7 @@ public function __invoke( $args, $assoc_args ) {
 
 		foreach ( $tables as $table ) {
 
-			if ( in_array( $table, $this->skip_tables ) ) {
+			if ( in_array( $table, $this->skip_tables, true ) ) {
 				continue;
 			}
 
@@ -340,11 +340,11 @@ public function __invoke( $args, $assoc_args ) {
 			}
 
 			foreach ( $columns as $col ) {
-				if ( ! empty( $this->include_columns ) && ! in_array( $col, $this->include_columns ) ) {
+				if ( ! empty( $this->include_columns ) && ! in_array( $col, $this->include_columns, true ) ) {
 					continue;
 				}
 
-				if ( in_array( $col, $this->skip_columns ) ) {
+				if ( in_array( $col, $this->skip_columns, true ) ) {
 					continue;
 				}
 
@@ -438,7 +438,7 @@ private function php_export_table( $table, $old, $new ) {
 			$row_fields = array();
 			foreach ( $all_columns as $col ) {
 				$value = $row->$col;
-				if ( $value && ! in_array( $col, $primary_keys ) && ! in_array( $col, $this->skip_columns ) ) {
+				if ( $value && ! in_array( $col, $primary_keys, true ) && ! in_array( $col, $this->skip_columns, true ) ) {
 					$new_value = $replacer->run( $value );
 					if ( $new_value !== $value ) {
 						$col_counts[ $col ]++;
@@ -595,7 +595,7 @@ private function write_sql_row_fields( $table, $rows ) {
 			//			$index % $export_insert_size == 0 && $index > 0
 			//		2. Or when the loop is running last time
 			//			$index == $count
-			if ( ( $index % $export_insert_size == 0 && $index > 0 ) || $index == $count ) {
+			if ( ( $index % $export_insert_size === 0 && $index > 0 ) || $index === $count ) {
 				$sql .= ";\n";
 
 				if ( method_exists( $wpdb, 'remove_placeholder_escape' ) ) {

src/WP_CLI/SearchReplacer.php

@@ -68,7 +68,7 @@ private function _run( $data, $serialised, $recursion_level = 0, $visited_data =
 			if ( $this->recurse_objects ) {
 
 				// If we've reached the maximum recursion level, short circuit
-				if ( $this->max_recursion != 0 && $recursion_level >= $this->max_recursion ) {
+				if ( $this->max_recursion !== 0 && $recursion_level >= $this->max_recursion ) {
 					return $data;
 				}