removing array cast & testing serialized, safe object to confirm serialization was successful

Author: MarkBerube

features/search-replace.feature

@@ -1107,7 +1107,6 @@ Feature: Do global search/replace
       """
 
   Scenario: Warn and ignore type-hinted objects that have some error in deserialization
-
     Given a WP install
     And I run `wp db query "INSERT INTO wp_options (option_name,option_value) VALUES ('cereal_isation','O:13:\"mysqli_result\":5:{s:13:\"current_field\";N;s:11:\"field_count\";N;s:7:\"lengths\";N;s:8:\"num_rows\";N;s:4:\"type\";N;}')"`
     And I run `wp db query "INSERT INTO wp_options (option_name,option_value) VALUES ('cereal_isation_2','O:8:\"mysqli_result\":5:{s:13:\"current_field\";i:1;s:11:\"field_count\";i:2;s:7:\"lengths\";a:1:{i:0;s:4:\"blah\";}s:8:\"num_rows\";i:1;s:4:\"type\";i:2;}')"`
@@ -1122,11 +1121,30 @@ Feature: Do global search/replace
       Success: Made 1 replacement.
       """
 
-    When I run `wp db query "SELECT option_value from wp_options where option_name='cereal_isation_2'"`
+    When I run `wp db query "SELECT option_value from wp_options where option_name='cereal_isation_2'" --skip-column-names`
     Then STDOUT should contain:
       """
       O:8:"stdClass":5:{s:13:"current_field";i:1;s:11:"field_count";i:2;s:7:"lengths";a:1:{i:0;s:4:"blah";}s:8:"num_rows";i:1;s:4:"type";i:2;}
       """
+    Then save STDOUT as {SERIALIZED_RESULT}
+    And a test_php.php file:
+      """
+      <?php print_r(unserialize('{SERIALIZED_RESULT}'));
+      """
+
+    When I try `wp eval-file test_php.php`
+    Then STDOUT should contain:
+      """
+      stdClass Object
+      """
+    Then STDOUT should contain:
+      """
+      [current_field] => 1
+      """
+    Then STDOUT should contain:
+      """
+      [field_count] => 2
+      """
 
   Scenario: Regex search/replace with `--regex-limit=1` option
     Given a WP install

src/WP_CLI/SearchReplacer.php

@@ -119,7 +119,7 @@ private function run_recursively( $data, $serialised, $recursion_level = 0, $vis
 						)
 					);
 				} else {
-					foreach ( (array) $data as $key => $value ) {
+					foreach ( $data as $key => $value ) {
 						$data->$key = $this->run_recursively( $value, false, $recursion_level + 1, $visited_data );
 					}
 				}