Merge pull request #169 from cjhaas/cjhaas-php81-null-to-explode

schlessera · web-flow · commit c8f57e1c675a · 2022-10-17T15:18:26.000-07:00
diff --git a/src/Search_Replace_Command.php b/src/Search_Replace_Command.php
@@ -223,9 +223,9 @@ public function __invoke( $args, $assoc_args ) {
 			}
 		}
 
-		$this->skip_columns    = explode( ',', Utils\get_flag_value( $assoc_args, 'skip-columns' ) );
-		$this->skip_tables     = explode( ',', Utils\get_flag_value( $assoc_args, 'skip-tables' ) );
-		$this->include_columns = array_filter( explode( ',', Utils\get_flag_value( $assoc_args, 'include-columns' ) ) );
+		$this->skip_columns    = explode( ',', Utils\get_flag_value( $assoc_args, 'skip-columns', '' ) );
+		$this->skip_tables     = explode( ',', Utils\get_flag_value( $assoc_args, 'skip-tables', '' ) );
+		$this->include_columns = array_filter( explode( ',', Utils\get_flag_value( $assoc_args, 'include-columns', '' ) ) );
 
 		if ( $old === $new && ! $this->regex ) {
 			WP_CLI::warning( "Replacement value '{$old}' is identical to search value '{$new}'. Skipping operation." );

Original file line number	Diff line number	Diff line change
`@@ -223,9 +223,9 @@ public function __invoke( $args, $assoc_args ) {`
`223`	`223`	`}`
`224`	`224`	`}`
`225`	`225`
`226`		`- $this->skip_columns = explode( ',', Utils\get_flag_value( $assoc_args, 'skip-columns' ) );`
`227`		`- $this->skip_tables = explode( ',', Utils\get_flag_value( $assoc_args, 'skip-tables' ) );`
`228`		`- $this->include_columns = array_filter( explode( ',', Utils\get_flag_value( $assoc_args, 'include-columns' ) ) );`
	`226`	`+ $this->skip_columns = explode( ',', Utils\get_flag_value( $assoc_args, 'skip-columns', '' ) );`
	`227`	`+ $this->skip_tables = explode( ',', Utils\get_flag_value( $assoc_args, 'skip-tables', '' ) );`
	`228`	`+ $this->include_columns = array_filter( explode( ',', Utils\get_flag_value( $assoc_args, 'include-columns', '' ) ) );`
`229`	`229`
`230`	`230`	`if ( $old === $new && ! $this->regex ) {`
`231`	`231`	`WP_CLI::warning( "Replacement value '{$old}' is identical to search value '{$new}'. Skipping operation." );`